Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 296283003: Re-Reland Linux Window Control Alignment (Closed)

Created:
6 years, 7 months ago by jonross
Modified:
6 years, 7 months ago
Reviewers:
flackr, oshima, sadrul
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Re-Reland Linux Window Control Alignment Modifying CustomFrameView to layout window controls based on user configurations. For linux begin observing the configs and changes. For other systems fall back on a default ordering. This reland addresses changes to custom_frame_view_unittest.cc that landed before the original patch. Causing a build failure. Original code review: https://codereview.chromium.org/281353009/ Revert code review: https://codereview.chromium.org/294473016 Revert "Revert 272352 "Reland Linux Window Control Alignment"" This reverts commit b6f34fbeb011683117b33639ca78d66ff32d5bfd. TBR=oshima, sadrul TEST=CustomFrameViewTest BUG=351917 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272576

Patch Set 1 #

Patch Set 2 : Fix Build Error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+575 lines, -71 lines) Patch
M ash/extended_desktop_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 5 chunks +19 lines, -2 lines 0 comments Download
A ui/views/linux_ui/window_button_order_provider.cc View 1 chunk +83 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 4 chunks +7 lines, -0 lines 0 comments Download
M ui/views/window/custom_frame_view.h View 6 chunks +20 lines, -3 lines 0 comments Download
M ui/views/window/custom_frame_view.cc View 11 chunks +94 lines, -63 lines 0 comments Download
A ui/views/window/custom_frame_view_unittest.cc View 1 1 chunk +252 lines, -0 lines 0 comments Download
A ui/views/window/window_button_order_provider.h View 1 chunk +56 lines, -0 lines 0 comments Download
A ui/views/window/window_button_order_provider.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jonross
Reland a patch, fix a trivial compilation error introduced by another change that landed first.
6 years, 7 months ago (2014-05-23 15:28:06 UTC) #1
flackr
lgtm
6 years, 7 months ago (2014-05-23 15:31:42 UTC) #2
sadrul
lgtm
6 years, 7 months ago (2014-05-23 15:33:14 UTC) #3
jonross
The CQ bit was checked by jonross@chromium.org
6 years, 7 months ago (2014-05-23 15:33:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/296283003/20001
6 years, 7 months ago (2014-05-23 15:34:13 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 19:05:42 UTC) #6
Message was sent while issue was closed.
Change committed as 272576

Powered by Google App Engine
This is Rietveld 408576698