Issue 294473016: Revert 272352 "Reland Linux Window Control Alignment"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294473016: Revert 272352 "Reland Linux Window Control Alignment" (Closed)

Created:
6 years, 7 months ago by fgorski

Modified:
6 years, 7 months ago

Reviewers:
jonross

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 272352 "Reland Linux Window Control Alignment" > Reland Linux Window Control Alignment > > Modifying CustomFrameView to layout window controls based on user configurations. For linux begin observing the configs and changes. For other systems fall back on a default ordering. > > Update tests that were originally missed. > > Original review: https://codereview.chromium.org/240163006/ > Revert review: https://codereview.chromium.org/276173002/ > Revert "Revert of Linux Aura Task Manager Frame Buttons Misaligned (https://codereview.chromium.org/240163006/)" > > This reverts commit 9031ef57ba679037fc675bf2f081f3880380de3a. > > TEST=CustomFrameViewTest > BUG=351917 > > Review URL: https://codereview.chromium.org/281353009 TBR=jonross@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272356

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -575 lines)			Patch
M	trunk/src/ash/extended_desktop_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/ash/wm/system_gesture_event_filter_unittest.cc	View	5 chunks	+2 lines, -19 lines	0 comments	Download
D	trunk/src/ui/views/linux_ui/window_button_order_provider.cc	View	1 chunk	+0 lines, -83 lines	0 comments	Download
M	trunk/src/ui/views/views.gyp	View	4 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/ui/views/window/custom_frame_view.h	View	6 chunks	+3 lines, -20 lines	0 comments	Download
M	trunk/src/ui/views/window/custom_frame_view.cc	View	11 chunks	+62 lines, -93 lines	0 comments	Download
D	trunk/src/ui/views/window/custom_frame_view_unittest.cc	View	1 chunk	+0 lines, -253 lines	0 comments	Download
D	trunk/src/ui/views/window/window_button_order_provider.h	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	trunk/src/ui/views/window/window_button_order_provider.cc	View	1 chunk	+0 lines, -41 lines	0 comments	Download

Total messages: 2 (0 generated)

fgorski

6 years, 7 months ago (2014-05-22 23:08:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r272356 (tree was closed).