AppShell: Enable chrome.fileSystem.retainEntry/restoreEntry

AppShell: Enable chrome.fileSystem.retainEntry/restoreEntry

Implement FileSystemDelegate for AppShell. Mostly NOT_IMPLEMENTED(),
but implements GetSavedFilesService().

This lets apps save and restore files in AppShell.

BUG=729713
Review-Url: https://codereview.chromium.org/2962793002
Cr-Commit-Position: refs/heads/master@{#487762}
Committed: https://chromium.googlesource.com/chromium/src/+/335a4e0fd2abb413d4242c0d272e06ca3d131142

[michaelpg, 2017-07-05 20:32:45]

Description was changed from

==========
AppShell: Enable chrome.fileSystem.retainEntry/restoreEntry

This provides a barebones FileSystemDelegate for AppShell which gives
the chrome.fileSystem API a pointer to the SavedFilesService, letting
apps save and restore files in AppShell.

BUG=729713
==========

to

==========
AppShell: Enable chrome.fileSystem.retainEntry/restoreEntry

This provides a barebones FileSystemDelegate for AppShell which gives
the chrome.fileSystem API a pointer to the SavedFilesService, letting
apps save and restore files in AppShell.

BUG=729713
==========

[michaelpg, 2017-07-14 02:59:54]

Description was changed from

==========
AppShell: Enable chrome.fileSystem.retainEntry/restoreEntry

This provides a barebones FileSystemDelegate for AppShell which gives
the chrome.fileSystem API a pointer to the SavedFilesService, letting
apps save and restore files in AppShell.

BUG=729713
==========

to

==========
AppShell: Enable chrome.fileSystem.retainEntry/restoreEntry

Implement FileSystemDelegate for AppShell. Mostly NOT_IMPLEMENTED(),
but implements GetSavedFilesService().

This lets apps save and restore files in AppShell.

BUG=729713
==========

[michaelpg, 2017-07-14 02:59:55]

michaelpg@chromium.org changed reviewers:
+ tbarzic@chromium.org

[michaelpg, 2017-07-14 03:00:09]

PTAL.

[tbarzic, 2017-07-14 20:37:38]

lgtm

https://codereview.chromium.org/2962793002/diff/40001/extensions/shell/browse...
File extensions/shell/browser/api/file_system/shell_file_system_delegate.cc
(right):

https://codereview.chromium.org/2962793002/diff/40001/extensions/shell/browse...
extensions/shell/browser/api/file_system/shell_file_system_delegate.cc:15:
ShellFileSystemDelegate::ShellFileSystemDelegate() {}
nit: = default

https://codereview.chromium.org/2962793002/diff/40001/extensions/shell/browse...
extensions/shell/browser/api/file_system/shell_file_system_delegate.cc:41:
NOTIMPLEMENTED();
nit: Running on_cancel would be a good default behavior, so it doesn't hang a
choose file function call, if ever called for a sensitive directory.

[michaelpg, 2017-07-18 05:00:16]

rebase

[michaelpg, 2017-07-18 05:00:36]

Patchset #4 (id:60001) has been deleted

[michaelpg, 2017-07-18 05:35:02]

michaelpg@chromium.org changed reviewers:
+ sky@chromium.org

[michaelpg, 2017-07-18 05:41:05]

sky: +ui/shell_dialogs in extensions/shell/browser/api/file_system/DEPS

tbarzic: Thanks!

https://codereview.chromium.org/2962793002/diff/40001/extensions/shell/browse...
File extensions/shell/browser/api/file_system/shell_file_system_delegate.cc
(right):

https://codereview.chromium.org/2962793002/diff/40001/extensions/shell/browse...
extensions/shell/browser/api/file_system/shell_file_system_delegate.cc:15:
ShellFileSystemDelegate::ShellFileSystemDelegate() {}
On 2017/07/14 20:37:37, tbarzic wrote:
> nit: = default

Done.

https://codereview.chromium.org/2962793002/diff/40001/extensions/shell/browse...
extensions/shell/browser/api/file_system/shell_file_system_delegate.cc:41:
NOTIMPLEMENTED();
On 2017/07/14 20:37:37, tbarzic wrote:
> nit: Running on_cancel would be a good default behavior, so it doesn't hang a
> choose file function call, if ever called for a sensitive directory.

Done. Also did this for ShowSelectFileDialog (and changed it to return true,
since false means it's explicitly disallowed so it was returning a confusing
error)

[sky, 2017-07-18 19:04:36]

Don't you also need to update a BUILD.gn to include shell_dialogs?

[michaelpg, 2017-07-18 21:27:50]

On 2017/07/18 19:04:36, sky wrote:
> Don't you also need to update a BUILD.gn to include shell_dialogs?

Oh, that's embarrassing: I removed the dependency on shell_dialogs from the code
in a previous patchset! Never mind, no DEPS changes needed... but thanks for
catching that.

[sky, 2017-07-18 23:02:26]

On 2017/07/18 21:27:50, michaelpg wrote:
> On 2017/07/18 19:04:36, sky wrote:
> > Don't you also need to update a BUILD.gn to include shell_dialogs?
> 
> Oh, that's embarrassing: I removed the dependency on shell_dialogs from the
code
> in a previous patchset! Never mind, no DEPS changes needed... but thanks for
> catching that.

No worries.

[michaelpg, 2017-07-19 04:07:28]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-07-19 04:07:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tbarzic@chromium.org
Link to the patchset: https://codereview.chromium.org/2962793002/#ps120001
(title: "Remove extraneous DEPS")

[commit-bot: I haz the power, 2017-07-19 04:07:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-19 05:18:42]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1500437248595890,
"parent_rev": "d3999e9237e394259301d8aa124e60e3d86f59bf", "commit_rev":
"cd3a575c296d0bae0a98a889f04c5e83b4e2c897"}

[commit-bot: I haz the power, 2017-07-19 05:19:02]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1500437248595890,
"parent_rev": "eb3c07f68b654e72aa171fc30b130a9991b0b0c8", "commit_rev":
"335a4e0fd2abb413d4242c0d272e06ca3d131142"}

[commit-bot: I haz the power, 2017-07-19 05:19:14]

Description was changed from

==========
AppShell: Enable chrome.fileSystem.retainEntry/restoreEntry

Implement FileSystemDelegate for AppShell. Mostly NOT_IMPLEMENTED(),
but implements GetSavedFilesService().

This lets apps save and restore files in AppShell.

BUG=729713
==========

to

==========
AppShell: Enable chrome.fileSystem.retainEntry/restoreEntry

Implement FileSystemDelegate for AppShell. Mostly NOT_IMPLEMENTED(),
but implements GetSavedFilesService().

This lets apps save and restore files in AppShell.

BUG=729713

Review-Url: https://codereview.chromium.org/2962793002
Cr-Commit-Position: refs/heads/master@{#487762}
Committed:
https://chromium.googlesource.com/chromium/src/+/335a4e0fd2abb413d4242c0d272e...
==========

[commit-bot: I haz the power, 2017-07-19 05:19:16]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/335a4e0fd2abb413d4242c0d272e...