Adding pystache to third_party

Adding pystache to third_party

BUG=734131, 734136
Review-Url: https://codereview.chromium.org/2962783004
Cr-Commit-Position: refs/heads/master@{#488641}
Committed: https://chromium.googlesource.com/chromium/src/+/938436754b8913bdfff87341189844b7f3cf7a57

[pkotwicz, 2017-06-28 20:54:01]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2017-06-28 20:57:28]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2017-06-28 21:29:24]

pkotwicz@chromium.org changed reviewers:
+ open-source-third-party-reviews@google.com

[pkotwicz, 2017-06-28 21:29:25]

Can you please take a look?

This CL makes use of pystache: https://codereview.chromium.org/2956193002/
 
The reason that I am adding pystache as a dependency is that
chrome/android/webapk/shell_apk/AndroidManifest.xml is:
- processed as part of the "WebApk.apk" Chromium build target (not Chrome.apk)
for the sake of local developer testing
- processed by the WebAPK server when Chrome requests a WebAPK install (The
server fills the Mustache template with values provided by Chrome)

A library which implements Mustache for Go is conveniently available in the
internal Google repository. There isn't a Go library which implements jinja in
the internal Google repository that I am aware of
MoTemplate is currently checked into Chromium at third_party/motemplate
MoTemplate is based on Mustache but is not Mustache

WebAPKs were presented at the Chrome Developer Summit and at Google I/O under
the name "Improved Add to Home screen". Reviewers, please ping me if you want
more details about the project.

[pkotwicz, 2017-06-29 20:07:08]

Description was changed from

==========
Adding pystache to third_party

BUG=734131, 734136
==========

to

==========
Adding pystache to third_party

BUG=734131, 734136
==========

[pkotwicz, 2017-06-29 20:07:08]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Yaron, 2017-06-30 01:12:05]

lgtm

[Yaron, 2017-07-05 17:15:38]

ostpr: please take a look
note that the library isn't used in chrome, it's just a tool we're using as part
of development process

[Yaron, 2017-07-11 18:57:24]

On 2017/07/05 17:15:38, Yaron wrote:
> ostpr: please take a look
> note that the library isn't used in chrome, it's just a tool we're using as
part
> of development process

open-source-third-party-reviews: can we get a quick look? The license appears to
be completely free to use and again, this is testing purposes in chromium and
not part of any shipping product

[pkotwicz, 2017-07-18 01:05:07]

Patchset #2 (id:60001) has been deleted

[pkotwicz, 2017-07-18 01:07:05]

pkotwicz@chromium.org changed reviewers:
+ xam@google.com

[pkotwicz, 2017-07-18 01:07:07]

xam@ can you please take another look? I have moved the pystache directory to
the root third_party/ directory as you have requested

[Yaron, 2017-07-18 15:00:36]

On 2017/07/18 01:07:07, pkotwicz wrote:
> xam@ can you please take another look? I have moved the pystache directory to
> the root third_party/ directory as you have requested

i think these should be in just //third_party not //chrome/third_party

[pkotwicz, 2017-07-18 15:34:43]

Patchset #4 (id:120001) has been deleted

[pkotwicz, 2017-07-18 15:34:51]

Patchset #3 (id:100001) has been deleted

[pkotwicz, 2017-07-18 15:35:24]

xam@ can you please take another look? The files are now in //third_party

[pkotwicz, 2017-07-19 18:57:53]

thakis@ for OWNERS

I have gotten chrome-eng-review@ and open-source-third-party-reviews@ approval
for adding pystache as a third_party dependency.

[pkotwicz, 2017-07-19 18:59:04]

pkotwicz@chromium.org changed reviewers:
+ thakis@chromium.org

[pkotwicz, 2017-07-19 18:59:25]

thakis@ for OWNERS

I have gotten chrome-eng-review@ and open-source-third-party-reviews@ approval
for adding pystache as a third_party dependency.

[pkotwicz, 2017-07-19 18:59:27]

thakis@ for OWNERS

I have gotten chrome-eng-review@ and open-source-third-party-reviews@ approval
for adding pystache as a third_party dependency.

[Nico, 2017-07-19 19:51:40]

We already use jinja2 for templating in a few places. Could that work for you?
If not, why not?

[pkotwicz, 2017-07-19 22:08:43]

We want to use pystache to template
chrome/android/webapk/shell_apk/AndroidManifest.xml
The template is filled in:
1) On the client (in Chrome code) for the sake of local testing. (For the sake
of clarity chrome/android/webapk/shell_apk/AndroidManifest.xml does not
contribute to Chrome.apk)
2) On a "Google Server" when a user taps "Add to homescreen" in the Chrome for
Android app menu. Values sent by Chrome are used to fill in the
AndroidManifest.xml and generate an APK for the site that the user is viewing

We want to use pystache (mustache for Python) in because it is available as a Go
library in google3. As far as I know there is no Go implementation of jinja2
(and said Go implementation has not been checked into Google3)

Please ping me if you have any questions or my explanation was unclear

[xam, 2017-07-20 04:47:16]

On 2017/07/19 22:08:43, pkotwicz wrote:
> We want to use pystache to template
> chrome/android/webapk/shell_apk/AndroidManifest.xml
> The template is filled in:
> 1) On the client (in Chrome code) for the sake of local testing. (For the sake
> of clarity chrome/android/webapk/shell_apk/AndroidManifest.xml does not
> contribute to Chrome.apk)
> 2) On a "Google Server" when a user taps "Add to homescreen" in the Chrome for
> Android app menu. Values sent by Chrome are used to fill in the
> AndroidManifest.xml and generate an APK for the site that the user is viewing
> 
> We want to use pystache (mustache for Python) in because it is available as a
Go
> library in google3. As far as I know there is no Go implementation of jinja2
> (and said Go implementation has not been checked into Google3)
> 
> Please ping me if you have any questions or my explanation was unclear

LGTM

[Nico, 2017-07-20 17:58:50]

lgtm

[pkotwicz, 2017-07-21 13:05:02]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-07-21 13:05:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/2962783004/#ps160001
(title: "Merge branch 'master' into mustache")

[commit-bot: I haz the power, 2017-07-21 13:05:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-21 13:18:29]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1500642302928710,
"parent_rev": "e74f918c10e5329113f1e4e6382e1f3ac86d6f41", "commit_rev":
"938436754b8913bdfff87341189844b7f3cf7a57"}

[commit-bot: I haz the power, 2017-07-21 13:18:45]

Description was changed from

==========
Adding pystache to third_party

BUG=734131, 734136
==========

to

==========
Adding pystache to third_party

BUG=734131, 734136

Review-Url: https://codereview.chromium.org/2962783004
Cr-Commit-Position: refs/heads/master@{#488641}
Committed:
https://chromium.googlesource.com/chromium/src/+/938436754b8913bdfff873411898...
==========

[commit-bot: I haz the power, 2017-07-21 13:18:46]

Committed patchset #4 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/938436754b8913bdfff873411898...