Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2962783003:
Implement ios language detection logging. (Closed)
|
Created:
3 years, 5 months ago by renjieliu1 Modified:
3 years, 5 months ago CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionImplement ios language detection logging.
BUG=722679
Review-Url: https://codereview.chromium.org/2962783003
Cr-Commit-Position: refs/heads/master@{#484417}
Committed: https://chromium.googlesource.com/chromium/src/+/4a1c9af8a6715969608c575157685203742d777d
Patch Set 1 #Patch Set 2 : updates #Patch Set 3 : updates #Messages
Total messages: 24 (18 generated)
The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Implement ios language detection logging. BUG=722679 ========== to ========== Implement ios language detection logging. BUG=722679 ==========
renjieliu@chromium.org changed reviewers: + napper@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
renjieliu@chromium.org changed reviewers: + droger@chromium.org
Added droger@ for ios review. Thank you!
lgtm
The CQ bit was checked by renjieliu@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499299401674350,
"parent_rev": "9d126b1389be2431d6c95eae379f5f0f059089c6", "commit_rev":
"4a1c9af8a6715969608c575157685203742d777d"}
Message was sent while issue was closed.
Description was changed from ========== Implement ios language detection logging. BUG=722679 ========== to ========== Implement ios language detection logging. BUG=722679 Review-Url: https://codereview.chromium.org/2962783003 Cr-Commit-Position: refs/heads/master@{#484417} Committed: https://chromium.googlesource.com/chromium/src/+/4a1c9af8a6715969608c57515768... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/4a1c9af8a6715969608c57515768... |
