Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2962723002:
Roll buildtools to 1dcd1bd (Closed)
|
Created:
3 years, 5 months ago by Tom Anderson Modified:
3 years, 5 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll buildtools to 1dcd1bd
This roll includes 5 revisions [1]. Revision [2] is needed for ARM
builds to work when statically linking libc++.
[1] https://chromium.googlesource.com/chromium/buildtools/+log/7f2cacbbe274ef9df2c94452e05e8702c3ae65a9..1dcd1bdbe93467531a50b60dbd18860803ca7be1
[2] https://chromium.googlesource.com/chromium/buildtools/+/1dcd1bdbe93467531a50b60dbd18860803ca7be1
BUG=593874
R=thakis@chromium.org
Review-Url: https://codereview.chromium.org/2962723002
Cr-Commit-Position: refs/heads/master@{#482740}
Committed: https://chromium.googlesource.com/chromium/src/+/4e58f6ee0938be997784c351ca6d8bba6ccaa654
Patch Set 1 #Messages
Total messages: 19 (8 generated)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + dpranke@chromium.org
dpranke, is rolling gn safe atm? I thought I saw some fire caused by the recent gn roll (but I don't remember details)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Yes, it should be safe to roll GN. A recent roll (last week) did break the world, but that change was reverted and we rolled past it. -- Dirk On Tue, Jun 27, 2017 at 12:08 PM, <thakis@chromium.org> wrote: > dpranke, is rolling gn safe atm? I thought I saw some fire caused by the > recent > gn roll (but I don't remember details) > > https://codereview.chromium.org/2962723002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
lgtm
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1498596727740950, "parent_rev":
"e17b1bcf1010c97436fadf6e58e9235b977c74ea", "commit_rev":
"4e58f6ee0938be997784c351ca6d8bba6ccaa654"}
Message was sent while issue was closed.
Description was changed from ========== Roll buildtools to 1dcd1bd This roll includes 5 revisions [1]. Revision [2] is needed for ARM builds to work when statically linking libc++. [1] https://chromium.googlesource.com/chromium/buildtools/+log/7f2cacbbe274ef9df2... [2] https://chromium.googlesource.com/chromium/buildtools/+/1dcd1bdbe93467531a50b... BUG=593874 R=thakis@chromium.org ========== to ========== Roll buildtools to 1dcd1bd This roll includes 5 revisions [1]. Revision [2] is needed for ARM builds to work when statically linking libc++. [1] https://chromium.googlesource.com/chromium/buildtools/+log/7f2cacbbe274ef9df2... [2] https://chromium.googlesource.com/chromium/buildtools/+/1dcd1bdbe93467531a50b... BUG=593874 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2962723002 Cr-Commit-Position: refs/heads/master@{#482740} Committed: https://chromium.googlesource.com/chromium/src/+/4e58f6ee0938be997784c351ca6d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/4e58f6ee0938be997784c351ca6d...
Message was sent while issue was closed.
On 2017/06/27 19:08:40, Nico (vacation Jun 30-Jul 11) wrote: > dpranke, is rolling gn safe atm? I thought I saw some fire caused by the recent > gn roll (but I don't remember details) Hmm ... now I'm powerfully confused.
Message was sent while issue was closed.
What do you mean? On Jun 27, 2017 5:07 PM, <dpranke@chromium.org> wrote: > On 2017/06/27 19:08:40, Nico (vacation Jun 30-Jul 11) wrote: > > dpranke, is rolling gn safe atm? I thought I saw some fire caused by the > recent > > gn roll (but I don't remember details) > > Hmm ... now I'm powerfully confused. > > https://codereview.chromium.org/2962723002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Oh, you probably mean that https://bugs.chromium.org/p/chromium/issues/detail?id=736215 returned after this landed. On Tue, Jun 27, 2017 at 5:17 PM, Nico Weber <thakis@chromium.org> wrote: > What do you mean? > > On Jun 27, 2017 5:07 PM, <dpranke@chromium.org> wrote: > >> On 2017/06/27 19:08:40, Nico (vacation Jun 30-Jul 11) wrote: >> > dpranke, is rolling gn safe atm? I thought I saw some fire caused by the >> recent >> > gn roll (but I don't remember details) >> >> Hmm ... now I'm powerfully confused. >> >> https://codereview.chromium.org/2962723002/ >> > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
I suspect the gn roll is causing some failures: https://build.chromium.org/p/client.nacl.sdk/builders/windows-sdk-multi/build... Dirk, can we revert the gn changes?
Message was sent while issue was closed.
On 2017/06/27 22:24:04, Tom Anderson wrote: > I suspect the gn roll is causing some failures: > https://build.chromium.org/p/client.nacl.sdk/builders/windows-sdk-multi/build... > > Dirk, can we revert the gn changes? I was referring to crbug.com/736215 being re-opened, yes, but that was reopened because of a failure that happened *before* this CL landed. The NaCl failure looks like a real failure and is likely unrelated to a GN change (I think). That said, whatever *is* going on w/ 736215 is strange and I'm digging into it more now. |
