[LayoutNG] Classify test failures

[LayoutNG] Classify test failures

This patch cleanup TestExpectaions by reviewing failures for:
  virtual/layout_ng/external/wpt/css/CSS2/linebox
  virtual/layout_ng/external/wpt/css/CSS2/normal-flow
and make them actionable.

TBR=eae@chromium.org, ikilpatrick@chromium.org
BUG=636993, 591099
Review-Url: https://codereview.chromium.org/2962693003
Cr-Commit-Position: refs/heads/master@{#482914}
Committed: https://chromium.googlesource.com/chromium/src/+/55911cd8d79455ec434081c1d986b4bad10d0454

[kojii, 2017-06-27 19:02:43]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 19:03:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 20:27:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 20:27:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-06-28 05:51:25]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 05:51:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 07:12:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 07:12:22]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-06-28 07:30:54]

Description was changed from

==========
TestExpectations

BUG=
==========

to

==========
[LayoutNG] Classify test failures

This patch cleanup TestExpectaions by reviewing failures for:
  virtual/layout_ng/external/wpt/css/CSS2/linebox
  virtual/layout_ng/external/wpt/css/CSS2/normal-flow
and make them actionable.

TBR=eae@chromium.org, ikilpatrick@chromium.org
BUG=636993, 591099
==========

[kojii, 2017-06-28 07:30:54]

kojii@chromium.org changed reviewers:
+ eae@chromium.org, ikilpatrick@chromium.org

[kojii, 2017-06-28 07:31:14]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-06-28 07:31:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 07:40:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498635074734020,
"parent_rev": "06083fbf5d49b0dce17d6b86cb82b79dd3305005", "commit_rev":
"55911cd8d79455ec434081c1d986b4bad10d0454"}

[commit-bot: I haz the power, 2017-06-28 07:40:46]

Description was changed from

==========
[LayoutNG] Classify test failures

This patch cleanup TestExpectaions by reviewing failures for:
  virtual/layout_ng/external/wpt/css/CSS2/linebox
  virtual/layout_ng/external/wpt/css/CSS2/normal-flow
and make them actionable.

TBR=eae@chromium.org, ikilpatrick@chromium.org
BUG=636993, 591099
==========

to

==========
[LayoutNG] Classify test failures

This patch cleanup TestExpectaions by reviewing failures for:
  virtual/layout_ng/external/wpt/css/CSS2/linebox
  virtual/layout_ng/external/wpt/css/CSS2/normal-flow
and make them actionable.

TBR=eae@chromium.org, ikilpatrick@chromium.org
BUG=636993, 591099

Review-Url: https://codereview.chromium.org/2962693003
Cr-Commit-Position: refs/heads/master@{#482914}
Committed:
https://chromium.googlesource.com/chromium/src/+/55911cd8d79455ec434081c1d986...
==========

[commit-bot: I haz the power, 2017-06-28 07:40:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/55911cd8d79455ec434081c1d986...

[cbiesinger, 2017-06-28 19:45:51]

cbiesinger@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[cbiesinger, 2017-06-28 19:45:52]

https://codereview.chromium.org/2962693003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2962693003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:411: # Block: centering by
auto-margins.
Why does that cause a failure? We support this.

[kojii, 2017-06-28 19:54:51]

https://codereview.chromium.org/2962693003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2962693003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:411: # Block: centering by
auto-margins.
On 2017/06/28 at 19:45:52, cbiesinger wrote:
> Why does that cause a failure? We support this.

Really, hm, maybe then it's caused by combination of some other thing. This test
has block and inline child, so anonymous doing something wrong?

[kojii, 2017-06-29 04:12:58]

On 2017/06/28 at 19:54:51, kojii wrote:
> On 2017/06/28 at 19:45:52, cbiesinger wrote:
> > Why does that cause a failure? We support this.
> 
> Really, hm, maybe then it's caused by combination of some other thing. This
test has block and inline child, so anonymous doing something wrong?

The test applies auto-margins to <img> with "display: block", so maybe a problem
is when NGBlockNode is not a LayoutNGBlockFlow or !CanUseNewLayout(). Thanks for
the info, it'll help where to look into.

[cbiesinger1, 2017-06-29 12:55:21]

On 2017/06/29 at 04:12:58, kojii wrote:
> On 2017/06/28 at 19:54:51, kojii wrote:
> > On 2017/06/28 at 19:45:52, cbiesinger wrote:
> > > Why does that cause a failure? We support this.
> > 
> > Really, hm, maybe then it's caused by combination of some other thing. This
test has block and inline child, so anonymous doing something wrong?
> 
> The test applies auto-margins to <img> with "display: block", so maybe a
problem is when NGBlockNode is not a LayoutNGBlockFlow or !CanUseNewLayout().
Thanks for the info, it'll help where to look into.

Interesting -- thanks for looking into that!