Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 2962673002: android: Turn on fission and symbol_level=2 by default.

Created:
3 years, 5 months ago by Nico
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use fission on Android, and in Linux release builds. Android's 32-bit binary was too large for the 32-bit ELF container with full symbols, so it switched to use symbol_level=1 by default. Fission makes the binary small enough that we can turn symbol_level=2 back on. Also, on Linux we only used fission if is_debug, while we should use it if symbol_level == 2 (i.e. both in debug and in release+symbols builds). BUG=735027, 721792

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : huh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -31 lines) Patch
M build/config/compiler/BUILD.gn View 4 chunks +1 line, -25 lines 0 comments Download
M build/config/compiler/compiler.gni View 1 2 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (12 generated)
Nico
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-27 14:53:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962673002/1
3 years, 5 months ago (2017-06-27 14:54:00 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-06-27 14:57:52 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/298424) android_compile_dbg on ...
3 years, 5 months ago (2017-06-27 14:57:53 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-27 15:18:32 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962673002/20001
3 years, 5 months ago (2017-06-27 15:18:43 UTC) #6
Nico
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-27 15:24:48 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962673002/40001
3 years, 5 months ago (2017-06-27 15:24:54 UTC) #8
Nico
Description was changed from ========== android: Turn on fission and symbol_level=2 by default. Android's 32-bit ...
3 years, 5 months ago (2017-06-27 15:26:27 UTC) #9
Nico
Description was changed from ========== Use fission on Android, and in Linux release builds. Android's ...
3 years, 5 months ago (2017-06-27 15:28:42 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-06-27 16:43:52 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 16:43:53 UTC) #12
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698