Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2859)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2962673002: android: Turn on fission and symbol_level=2 by default.
Patch Set: huh Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index d6392d1df7b2618bd3a7ba5a86129f039aa9babb..efbf047f616888a1502f5bb4d87d5f4202b07a5b 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -6,7 +6,6 @@ import("//build/config/android/config.gni")
import("//build/config/chrome_build.gni")
import("//build/config/chromecast_build.gni")
import("//build/config/compiler/compiler.gni")
-import("//build/toolchain/cc_wrapper.gni")
import("//build/toolchain/toolchain.gni")
import("//build_overrides/build.gni")
@@ -125,11 +124,6 @@ if (gold_path == false) {
}
}
-if (use_debug_fission == "default") {
- use_debug_fission =
- is_debug && !is_android && !is_win && use_gold && cc_wrapper == ""
-}
-
# default_include_dirs ---------------------------------------------------------
#
# This is a separate config so that third_party code (which would not use the
@@ -1724,14 +1718,6 @@ config("symbols") {
# dump_syms, so this is still required (https://crbug.com/622406).
cflags += [ "-fno-standalone-debug" ]
}
- } else if (is_android) {
- # Breakpad can't handle DWARF 4 symbols properly yet, so use DWARF 3
- # explicitly on android where we are hitting https://crbug.com/638485.
- # The arguments MUST be in this order because of a gcc arg parsing bug.
- cflags = [
- "-gdwarf-3",
- "-g2",
- ]
} else {
cflags = [ "-g2" ]
}
@@ -1765,17 +1751,7 @@ config("minimal_symbols") {
cflags = []
ldflags = [ "/DEBUG" ]
} else {
- if (is_android) {
- # Breakpad can't handle DWARF 4 symbols properly yet, so use DWARF 3
- # explicitly on android where we are hitting https://crbug.com/638485.
- # The arguments MUST be in this order because of a gcc arg parsing bug.
- cflags = [
- "-gdwarf-3",
- "-g1",
- ]
- } else {
- cflags = [ "-g1" ]
- }
+ cflags = [ "-g1" ]
# Note: -gsplit-dwarf implicitly turns on -g2 with clang, so don't pass it.
asmflags = cflags
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698