[Media Router] Clean up OffscreenPresentationManager params.

[Media Router] Clean up OffscreenPresentationManager params.

Presentation ID + URL -> content::PresentationInfo
Also clean up class comments on usage.

BUG=737160
Review-Url: https://codereview.chromium.org/2962623002
Cr-Commit-Position: refs/heads/master@{#484791}
Committed: https://chromium.googlesource.com/chromium/src/+/7e5dc58f0e1c227524b2181232f01041a77603e3

[imcheng, 2017-06-27 06:42:25]

Description was changed from

==========
[Media Router] Clean up OffscreenPresentationManager params.

Presentation ID + URL -> content::PresentationInfo
==========

to

==========
[Media Router] Clean up OffscreenPresentationManager params.

Presentation ID + URL -> content::PresentationInfo
Also clean up class comments on usage.
==========

[imcheng, 2017-06-27 07:52:35]

The CQ bit was checked by imcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 07:52:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 08:52:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 08:52:24]

Dry run: This issue passed the CQ dry run.

[imcheng, 2017-06-28 00:28:09]

imcheng@chromium.org changed reviewers:
+ zhaobin@chromium.org

[imcheng, 2017-06-28 00:28:09]

Bin: PTAL

[zhaobin, 2017-06-28 06:46:26]

lgtm

https://codereview.chromium.org/2962623002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
(right):

https://codereview.chromium.org/2962623002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc:88:
void(const std::string& presentation_id,
Change this to content::PresentationInfo as well? Does not really matter
though...

[imcheng, 2017-06-29 06:53:04]

The CQ bit was checked by imcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 06:53:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[imcheng, 2017-06-29 06:56:26]

https://codereview.chromium.org/2962623002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
(right):

https://codereview.chromium.org/2962623002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc:88:
void(const std::string& presentation_id,
On 2017/06/28 06:46:26, zhaobin wrote:
> Change this to content::PresentationInfo as well? Does not really matter
> though...

Done. I added a matcher for PresentationInfo in this test.

[imcheng, 2017-06-29 07:03:15]

The CQ bit was checked by imcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 07:03:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 08:08:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 08:08:55]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[imcheng, 2017-06-29 19:05:28]

Description was changed from

==========
[Media Router] Clean up OffscreenPresentationManager params.

Presentation ID + URL -> content::PresentationInfo
Also clean up class comments on usage.
==========

to

==========
[Media Router] Clean up OffscreenPresentationManager params.

Presentation ID + URL -> content::PresentationInfo
Also clean up class comments on usage.

BUG=737160
==========

[imcheng, 2017-07-05 19:38:36]

imcheng@chromium.org changed reviewers:
+ kmarshall@chromium.org

[imcheng, 2017-07-05 19:38:37]

+kmarshall for committers

[Kevin M, 2017-07-06 22:39:13]

lgtm

[imcheng, 2017-07-06 22:58:39]

The CQ bit was checked by imcheng@chromium.org

[imcheng, 2017-07-06 22:58:39]

The patchset sent to the CQ was uploaded after l-g-t-m from zhaobin@chromium.org
Link to the patchset: https://codereview.chromium.org/2962623002/#ps40001
(title: "Addressed Bin's comments")

[commit-bot: I haz the power, 2017-07-06 22:58:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 23:07:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 23:07:25]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[imcheng, 2017-07-07 00:12:31]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2017-07-07 00:12:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 02:05:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499386351845520,
"parent_rev": "0add0bb7648bc76c8bf17b7824c34b2596d1e974", "commit_rev":
"7e5dc58f0e1c227524b2181232f01041a77603e3"}

[commit-bot: I haz the power, 2017-07-07 02:05:41]

Description was changed from

==========
[Media Router] Clean up OffscreenPresentationManager params.

Presentation ID + URL -> content::PresentationInfo
Also clean up class comments on usage.

BUG=737160
==========

to

==========
[Media Router] Clean up OffscreenPresentationManager params.

Presentation ID + URL -> content::PresentationInfo
Also clean up class comments on usage.

BUG=737160

Review-Url: https://codereview.chromium.org/2962623002
Cr-Commit-Position: refs/heads/master@{#484791}
Committed:
https://chromium.googlesource.com/chromium/src/+/7e5dc58f0e1c227524b2181232f0...
==========

[commit-bot: I haz the power, 2017-07-07 02:05:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7e5dc58f0e1c227524b2181232f0...