Chromium Code Reviews Chromium Code Reviews
Issue
2962613002:
[Merge to 3141] Revert "Image Capture win: initialize camera controls lazily" (Closed)
Description[Merge to 3141] Revert "Image Capture win: initialize camera controls lazily"
This reverts commit 0034bdea7ead45fc8738b68bbf1eb9d037eece33.
Reason for revert: Reverting on recommendation of ligimole@ for being a top crasher in Canary:
https://bugs.chromium.org/p/chromium/issues/detail?id=736368
Original change's description:
> Image Capture win: initialize camera controls lazily
>
> ToT initializes |camera_control_| and |video_control_|
> during AllocateAndStart(), which causes issues for clients
> who just want video capture. This CL corrects this by
> delaying initialization of the said member variables to
> when they are needed, that is, when calling GetPhotoState()
> or SetPhotoOptions().
>
> Bug: 722038
> Change-Id: I9d98075c53ec1519057187a722f5f8747fd12fde
> Reviewed-on: https://chromium-review.googlesource.com/543198
> Reviewed-by: Christian Fremerey <chfremer@chromium.org>;
> Commit-Queue: Miguel Casas <mcasas@chromium.org>;
> Cr-Commit-Position: refs/heads/master@{#481401}
TBR=mcasas@chromium.org,chfremer@chromium.org
Bug: 722038
Change-Id: I573d6a956e6ab7614df981c966dc15b5c2349a0f
Reviewed-on: https://chromium-review.googlesource.com/549059
Reviewed-by: Erik Chen <erikchen@chromium.org>;
Commit-Queue: Erik Chen <erikchen@chromium.org>;
Cr-Original-Commit-Position: refs/heads/master@{#482432}
Review-Url: https://codereview.chromium.org/2962613002 .
Cr-Commit-Position: refs/branch-heads/3141@{#7}
Cr-Branched-From: 180095eb1bca7df1cdcb02547340499c2ee3af6e-refs/heads/master@{#482153}
Committed: https://chromium.googlesource.com/chromium/src/+/89ec7939fd60622719d440296e99f1feacc09ac1
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||
