Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2962573002: Move SetReferrerForRequest method from WebFrame to WebLocalFrame. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
watk, chrishtr
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SetReferrerForRequest method from WebFrame to WebLocalFrame. The SetReferrerForRequest method needs to access Document, which doesn't make sense for a remote frame. Therefore, this CL moves this method from WebFrame to WebLocalFrame. The caller in content/renderer/pepper/url_request_info_util.cc already calls through WebLocalFrame. The caller in media/blink/resource_multibuffer_data_provider.cc calls through WebLocalFrame, but doesn't realize it. This CL changes s/WebFrame/WebLocalFrame/ in a few places under media/blink to make this explicit. No intended behavior change. BUG=416660 Review-Url: https://codereview.chromium.org/2962573002 Cr-Commit-Position: refs/heads/master@{#482885} Committed: https://chromium.googlesource.com/chromium/src/+/3034ad79e9d6a0ccdd067608b172b7ff126b3689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -25 lines) Patch
M media/blink/multibuffer_data_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/url_index.h View 6 chunks +7 lines, -7 lines 0 comments Download
M media/blink/url_index.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRemoteFrameClient.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
Łukasz Anforowicz
watk@, could you PTAL?
3 years, 5 months ago (2017-06-26 20:52:11 UTC) #5
watk
lgtm
3 years, 5 months ago (2017-06-27 17:54:21 UTC) #8
Łukasz Anforowicz
chrishtr@, could you PTAL? (I used to send CLs related to https://crbug.com/416660 to dcheng@, but ...
3 years, 5 months ago (2017-06-27 18:06:30 UTC) #10
chrishtr
Why doesn't it make sense for a remote frame? Shouldn't setting referrers work for all ...
3 years, 5 months ago (2017-06-27 21:36:16 UTC) #11
Łukasz Anforowicz
On 2017/06/27 21:36:16, chrishtr wrote: > Why doesn't it make sense for a remote frame? ...
3 years, 5 months ago (2017-06-27 22:09:28 UTC) #12
chrishtr
lgtm
3 years, 5 months ago (2017-06-27 22:10:35 UTC) #13
Łukasz Anforowicz
Thanks for the reviews!
3 years, 5 months ago (2017-06-27 22:25:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962573002/1
3 years, 5 months ago (2017-06-27 22:25:46 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/489429)
3 years, 5 months ago (2017-06-28 00:38:26 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962573002/1
3 years, 5 months ago (2017-06-28 04:05:12 UTC) #20
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 04:53:50 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3034ad79e9d6a0ccdd067608b172...

Powered by Google App Engine
This is Rietveld 408576698