Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2962563002: cc: Add CHECKs for diagnosing invalid property tree indices post-commit. (Closed)

Created:
3 years, 5 months ago by Khushal
Modified:
3 years, 5 months ago
Reviewers:
weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add CHECKs for diagnosing invalid property tree indices post-commit. Include mask layers when validating property tree indices post layer update, and peform this check right before starting commit as well. BUG=726423 R=weiliangc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2962563002 Cr-Commit-Position: refs/heads/master@{#482394} Committed: https://chromium.googlesource.com/chromium/src/+/1ec4a223a498c48e5f510a580c9890479f5714b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M cc/trees/layer_tree_host.cc View 3 chunks +27 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Khushal
3 years, 5 months ago (2017-06-26 18:58:55 UTC) #2
weiliangc
lgtm
3 years, 5 months ago (2017-06-26 19:52:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962563002/1
3 years, 5 months ago (2017-06-26 19:53:21 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 21:06:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1ec4a223a498c48e5f510a580c98...

Powered by Google App Engine
This is Rietveld 408576698