Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2962553002:
Setting story names for stories in media_router_perf_pages (Closed)
|
Created:
3 years, 5 months ago by ashleymarie1 Modified:
3 years, 5 months ago CC:
chromium-reviews, imcheng+watch_chromium.org, mfoltz+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionSetting story names for stories in media_router_perf_pages
As a part of bug 720002, we're asserting that all stories be named,
even stories used in tests.
BUG=chromium:720002
Review-Url: https://codereview.chromium.org/2962553002
Cr-Commit-Position: refs/heads/master@{#482368}
Committed: https://chromium.googlesource.com/chromium/src/+/e027709aa25e656c45e3aeca3171925e85280c45
Patch Set 1 #
Messages
Total messages: 25 (13 generated)
The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ashleymarie@chromium.org changed reviewers: + cliffordcheng@chromium.org, mfoltz@chromium.org
We're getting rid of the verify_names flag since it was intended to be temporary while transitioning stories to have names (related to https://codereview.chromium.org/2949063003)
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ashleymarie@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
ashleymarie@chromium.org changed reviewers: + nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2017/06/26 19:12:59, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Ah looks like I need OWNERS still Mark Foltz, are you an owner here?
lgtm
The CQ bit was checked by ashleymarie@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1498507097802700, "parent_rev":
"f7c606a926fc0063f1de820414ecc8ea7fa236d1", "commit_rev":
"e027709aa25e656c45e3aeca3171925e85280c45"}
Message was sent while issue was closed.
Description was changed from ========== Setting story names for stories in media_router_perf_pages As a part of bug 720002, we're asserting that all stories be named, even stories used in tests. BUG=chromium:720002 ========== to ========== Setting story names for stories in media_router_perf_pages As a part of bug 720002, we're asserting that all stories be named, even stories used in tests. BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2962553002 Cr-Commit-Position: refs/heads/master@{#482368} Committed: https://chromium.googlesource.com/chromium/src/+/e027709aa25e656c45e3aeca3171... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e027709aa25e656c45e3aeca3171... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
