Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2962503002: [turbofan] Fix an assertion in representation selection for BooleanNot. (Closed)

Created:
3 years, 5 months ago by Jarin
Modified:
3 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix an assertion in representation selection for BooleanNot. BUG=chromium:736567 Review-Url: https://codereview.chromium.org/2962503002 Cr-Commit-Position: refs/heads/master@{#46216} Committed: https://chromium.googlesource.com/v8/v8/+/bdf1b0a84ae4ce3f76b5deb86a63e1c5f7fc2b90

Patch Set 1 #

Patch Set 2 : Relax the check even more. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M src/compiler/simplified-lowering.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
A test/mjsunit/compiler/regress-736567.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Jarin
Could you take a look, please?
3 years, 5 months ago (2017-06-26 12:31:08 UTC) #4
Benedikt Meurer
lgtm
3 years, 5 months ago (2017-06-26 12:50:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962503002/20001
3 years, 5 months ago (2017-06-26 13:17:03 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 13:49:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/bdf1b0a84ae4ce3f76b5deb86a63e1c5f7f...

Powered by Google App Engine
This is Rietveld 408576698