Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp

Issue 2962353002: Add probe for V8.Complie (Closed)
Patch Set: fix tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
index 736f88472da24788778ae8681e14e0c9e9724b6a..05810cd8242f4fb5afed5f484be2cd8e8f19255b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
@@ -60,8 +60,10 @@ class V8ScriptRunnerTest : public ::testing::Test {
bool CompileScript(v8::Isolate* isolate, V8CacheOptions cache_options) {
return !V8ScriptRunner::CompileScript(
+ ScriptState::Current(isolate),
haraken 2017/07/19 05:51:19 Using ScriptState::Current is not nice unless you'
Liquan (Max) Gu 2017/07/19 15:04:44 Done.
+
V8String(isolate, Code()), Filename(), String(),
- WTF::TextPosition(), isolate, resource_.Get(), nullptr,
+ WTF::TextPosition(), resource_.Get(), nullptr,
resource_.Get() ? resource_->CacheHandler() : nullptr,
kNotSharableCrossOrigin, cache_options)
.IsEmpty();

Powered by Google App Engine
This is Rietveld 408576698