Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp

Issue 2962353002: Add probe for V8.Complie (Closed)
Patch Set: fix tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/V8ScriptRunner.h" 5 #include "bindings/core/v8/V8ScriptRunner.h"
6 6
7 #include "bindings/core/v8/V8BindingForCore.h" 7 #include "bindings/core/v8/V8BindingForCore.h"
8 #include "bindings/core/v8/V8BindingForTesting.h" 8 #include "bindings/core/v8/V8BindingForTesting.h"
9 #include "core/loader/resource/ScriptResource.h" 9 #include "core/loader/resource/ScriptResource.h"
10 #include "platform/heap/Handle.h" 10 #include "platform/heap/Handle.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 } 53 }
54 unsigned TagForCodeCache(CachedMetadataHandler* cache_handler) const { 54 unsigned TagForCodeCache(CachedMetadataHandler* cache_handler) const {
55 return V8ScriptRunner::TagForCodeCache(cache_handler); 55 return V8ScriptRunner::TagForCodeCache(cache_handler);
56 } 56 }
57 void SetCacheTimeStamp(CachedMetadataHandler* cache_handler) { 57 void SetCacheTimeStamp(CachedMetadataHandler* cache_handler) {
58 V8ScriptRunner::SetCacheTimeStamp(cache_handler); 58 V8ScriptRunner::SetCacheTimeStamp(cache_handler);
59 } 59 }
60 60
61 bool CompileScript(v8::Isolate* isolate, V8CacheOptions cache_options) { 61 bool CompileScript(v8::Isolate* isolate, V8CacheOptions cache_options) {
62 return !V8ScriptRunner::CompileScript( 62 return !V8ScriptRunner::CompileScript(
63 ScriptState::Current(isolate),
haraken 2017/07/19 05:51:19 Using ScriptState::Current is not nice unless you'
Liquan (Max) Gu 2017/07/19 15:04:44 Done.
64
63 V8String(isolate, Code()), Filename(), String(), 65 V8String(isolate, Code()), Filename(), String(),
64 WTF::TextPosition(), isolate, resource_.Get(), nullptr, 66 WTF::TextPosition(), resource_.Get(), nullptr,
65 resource_.Get() ? resource_->CacheHandler() : nullptr, 67 resource_.Get() ? resource_->CacheHandler() : nullptr,
66 kNotSharableCrossOrigin, cache_options) 68 kNotSharableCrossOrigin, cache_options)
67 .IsEmpty(); 69 .IsEmpty();
68 } 70 }
69 71
70 void SetEmptyResource() { 72 void SetEmptyResource() {
71 resource_ = ScriptResource::CreateForTest(NullURL(), UTF8Encoding()); 73 resource_ = ScriptResource::CreateForTest(NullURL(), UTF8Encoding());
72 } 74 }
73 75
74 void SetResource() { 76 void SetResource() {
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 // The cached data is associated with the encoding. 128 // The cached data is associated with the encoding.
127 ScriptResource* another_resource = 129 ScriptResource* another_resource =
128 ScriptResource::CreateForTest(Url(), UTF16LittleEndianEncoding()); 130 ScriptResource::CreateForTest(Url(), UTF16LittleEndianEncoding());
129 EXPECT_FALSE(CacheHandler()->GetCachedMetadata( 131 EXPECT_FALSE(CacheHandler()->GetCachedMetadata(
130 TagForCodeCache(another_resource->CacheHandler()))); 132 TagForCodeCache(another_resource->CacheHandler())));
131 } 133 }
132 134
133 } // namespace 135 } // namespace
134 136
135 } // namespace blink 137 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698