Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

Issue 2962353002: Add probe for V8.Complie (Closed)
Patch Set: correct executionContext usage Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
index ebff9136c1d33a332f3f4f1e20a1c42c38ea1a35..beaba612c1aa9f97bcce7e465a72ce569584a237 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
@@ -53,11 +53,13 @@ class CORE_EXPORT V8ScriptRunner final {
public:
// For the following methods, the caller sites have to hold
// a HandleScope and a ContextScope.
- static v8::MaybeLocal<v8::Script> CompileScript(const ScriptSourceCode&,
+ static v8::MaybeLocal<v8::Script> CompileScript(ExecutionContext*,
haraken 2017/07/18 05:18:17 In a follow-up CL, would you make a change to pass
Liquan (Max) Gu 2017/07/18 21:18:49 Done.
+ const ScriptSourceCode&,
v8::Isolate*,
AccessControlStatus,
V8CacheOptions);
- static v8::MaybeLocal<v8::Script> CompileScript(const String&,
+ static v8::MaybeLocal<v8::Script> CompileScript(ExecutionContext*,
+ const String&,
const String& file_name,
const String& source_map_url,
const TextPosition&,
@@ -69,7 +71,8 @@ class CORE_EXPORT V8ScriptRunner final {
// normal scripe resources, CachedMetadataHandler is from ScriptResource.
// For worker script, ScriptResource is null but CachedMetadataHandler may be
// set. When ScriptStreamer is set, ScriptResource must be set.
- static v8::MaybeLocal<v8::Script> CompileScript(v8::Local<v8::String>,
+ static v8::MaybeLocal<v8::Script> CompileScript(ExecutionContext*,
+ v8::Local<v8::String>,
const String& file_name,
const String& source_map_url,
const TextPosition&,
@@ -88,6 +91,7 @@ class CORE_EXPORT V8ScriptRunner final {
v8::Local<v8::Script>,
ExecutionContext*);
static v8::MaybeLocal<v8::Value> CompileAndRunInternalScript(
+ ExecutionContext*,
v8::Local<v8::String>,
v8::Isolate*,
const String& = String(),

Powered by Google App Engine
This is Rietveld 408576698