Add probe for V8.Complie

third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 35 matching lines @@
 class ScriptSourceCode;
 class ExecutionContext;
 class ScriptStreamer;
 
 class CORE_EXPORT V8ScriptRunner final {
   STATIC_ONLY(V8ScriptRunner);
 
  public:
   // For the following methods, the caller sites have to hold
   // a HandleScope and a ContextScope.
-  static v8::MaybeLocal<v8::Script> CompileScript(const ScriptSourceCode&,
+  static v8::MaybeLocal<v8::Script> CompileScript(ExecutionContext*,

[haraken, 2017/07/18 05:18:17]

In a follow-up CL, would you make a change to pass in ScriptState* to these
methods? Then you don't need to pass both ExecutionContext* and Isolate*. We can
get ExecutionContext* and Isolate* from ScriptState*.

[Liquan (Max) Gu, 2017/07/18 21:18:49]

Done.

+                                                  const ScriptSourceCode&,
                                                   v8::Isolate*,
                                                   AccessControlStatus,
                                                   V8CacheOptions);
-  static v8::MaybeLocal<v8::Script> CompileScript(const String&,
+  static v8::MaybeLocal<v8::Script> CompileScript(ExecutionContext*,
+                                                  const String&,
                                                   const String& file_name,
                                                   const String& source_map_url,
                                                   const TextPosition&,
                                                   v8::Isolate*,
                                                   CachedMetadataHandler*,
                                                   AccessControlStatus,
                                                   V8CacheOptions);
   // CachedMetadataHandler is set when metadata caching is supported. For
   // normal scripe resources, CachedMetadataHandler is from ScriptResource.
   // For worker script, ScriptResource is null but CachedMetadataHandler may be
   // set. When ScriptStreamer is set, ScriptResource must be set.
-  static v8::MaybeLocal<v8::Script> CompileScript(v8::Local<v8::String>,
+  static v8::MaybeLocal<v8::Script> CompileScript(ExecutionContext*,
+                                                  v8::Local<v8::String>,
                                                   const String& file_name,
                                                   const String& source_map_url,
                                                   const TextPosition&,
                                                   v8::Isolate*,
                                                   ScriptResource*,
                                                   ScriptStreamer*,
                                                   CachedMetadataHandler*,
                                                   AccessControlStatus,
                                                   V8CacheOptions);
   static v8::MaybeLocal<v8::Module> CompileModule(v8::Isolate*,
                                                   const String& source,
                                                   const String& file_name,
                                                   AccessControlStatus,
                                                   const TextPosition&);
   static v8::MaybeLocal<v8::Value> RunCompiledScript(v8::Isolate*,
                                                      v8::Local<v8::Script>,
                                                      ExecutionContext*);
   static v8::MaybeLocal<v8::Value> CompileAndRunInternalScript(
+      ExecutionContext*,
       v8::Local<v8::String>,
       v8::Isolate*,
       const String& = String(),
       const TextPosition& = TextPosition());
   static v8::MaybeLocal<v8::Value> RunCompiledInternalScript(
       v8::Isolate*,
       v8::Local<v8::Script>);
   static v8::MaybeLocal<v8::Value> CallAsConstructor(
       v8::Isolate*,
       v8::Local<v8::Object>,
@@ skipping 51 matching lines @@
  private:
   static v8::MaybeLocal<v8::Value> CallExtraHelper(ScriptState*,
                                                    const char* name,
                                                    size_t num_args,
                                                    v8::Local<v8::Value>* args);
 };
 
 }  // namespace blink
 
 #endif  // V8ScriptRunner_h