third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp - Issue 2962353002: Add probe for V8.Complie

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

Issue 2962353002: Add probe for V8.Complie (Closed)

Patch Set: correct executionContext usage Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp b/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

index 3465546bae78bd5871998ad523d66b8a256c4217..c2225217ee2a1a23d890b48f47eff1490b0034a5 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

@@ -142,8 +142,9 @@ bool DocumentWriteEvaluator::Evaluate(const String& script_source) {

if (source.IsEmpty())

return false;

v8::TryCatch try_catch(isolate);

- return !V8ScriptRunner::CompileAndRunInternalScript(source.ToLocalChecked(),

- isolate)

+ return !V8ScriptRunner::CompileAndRunInternalScript(

+ ExecutionContext::From(ScriptState::Current(isolate)),

+ source.ToLocalChecked(), isolate)

.IsEmpty();

}