Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2962333002: VM-codegen: Restrict widening class ranges in method dispatch (Closed)

Created:
3 years, 5 months ago by erikcorry
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM-codegen: Restrict widening class ranges in method dispatch We widen the range of class-ids that we dispatch to if the neighbouring classes dispatch to the same methods. With this change we don't widen the range to encompass abstract classes unless we also catch more concrete classes in that way. This improves the Megamorhphic benchmark suite scores by about 10% on average. This is split off from https://codereview.chromium.org/2955073005/ R=vegorov@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1ef0ec401a1498ea2ce4b03a44d1a418f9283c79

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M runtime/vm/flow_graph_compiler.h View 1 chunk +2 lines, -1 line 1 comment Download
M runtime/vm/flow_graph_compiler.cc View 2 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
erikcorry
3 years, 5 months ago (2017-06-30 15:43:44 UTC) #1
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/2962333002/diff/1/runtime/vm/flow_graph_compiler.h File runtime/vm/flow_graph_compiler.h (right): https://codereview.chromium.org/2962333002/diff/1/runtime/vm/flow_graph_compiler.h#newcode612 runtime/vm/flow_graph_compiler.h:612: bool* class_is_abstract_return = NULL); maybe just class_is_abstract?
3 years, 5 months ago (2017-06-30 16:53:21 UTC) #2
erikcorry
3 years, 5 months ago (2017-07-03 07:27:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ef0ec401a1498ea2ce4b03a44d1a418f9283c79 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698