runtime/vm/flow_graph_compiler.h - Issue 2962333002: VM-codegen: Restrict widening class ranges in method dispatch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.h

Issue 2962333002: VM-codegen: Restrict widening class ranges in method dispatch (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler.h

diff --git a/runtime/vm/flow_graph_compiler.h b/runtime/vm/flow_graph_compiler.h

index 0e91b00f39f13665cf97adf257fa9af5063623c6..0a7949af78c92d50caccbfdce8545ce91240c137 100644

--- a/runtime/vm/flow_graph_compiler.h

+++ b/runtime/vm/flow_graph_compiler.h

@@ -608,7 +608,8 @@ class FlowGraphCompiler : public ValueObject {

static bool LookupMethodFor(int class_id,

const String& name,

const ArgumentsDescriptor& args_desc,

- Function* fn_return);

+ Function* fn_return,

+ bool* class_is_abstract_return = NULL);

Vyacheslav Egorov (Google) 2017/06/30 16:53:21 maybe just class_is_abstract?

#if defined(TARGET_ARCH_DBC)

enum CallResult {

« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler.cc » ('j') | no next file with comments »