MD Bookmarks: Add 'show in folder' command to search result context menu

MD Bookmarks: Add 'show in folder' command to search result context menu

BUG=727174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2962283002
Cr-Commit-Position: refs/heads/master@{#486678}
Committed: https://chromium.googlesource.com/chromium/src/+/d16c95a41c56a1b7b78a786347a3eb6a3bb06ef8

[tsergeant, 2017-06-30 05:22:32]

Description was changed from

==========
MD Bookmarks: Add 'show in folder' command to search result context menu

BUG=727174
==========

to

==========
MD Bookmarks: Add 'show in folder' command to search result context menu

BUG=727174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-06-30 05:30:50]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 05:30:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 06:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 06:41:34]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-07-06 06:37:45]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 06:37:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 09:18:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 09:18:44]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-07-07 03:17:15]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-07-07 03:17:16]

PTAL. As discussed, it doesn't select the item and returns focus to the old
<bookmark-item>. I'm working on the follow-up for these now.

[calamity, 2017-07-10 05:51:38]

https://codereview.chromium.org/2962283002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/command_manager.js (right):

https://codereview.chromium.org/2962283002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.js:206: // search before
the menu is displayed.
Why not add a source to openCommandMenuAtPostion/Element? This hack is a bit too
implicit for my liking.

[tsergeant, 2017-07-11 02:42:08]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-11 02:42:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-07-11 02:58:59]

https://codereview.chromium.org/2962283002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/command_manager.js (right):

https://codereview.chromium.org/2962283002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.js:206: // search before
the menu is displayed.
On 2017/07/10 05:51:38, calamity wrote:
> Why not add a source to openCommandMenuAtPostion/Element? This hack is a bit
too
> implicit for my liking.

Done. I've added a MenuSource to the list for determining why it was opened.
It's not a perfect system still (it doesn't work for keyboard shortcuts,
really), but it's enough for what we need now.

[commit-bot: I haz the power, 2017-07-11 04:02:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 04:02:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[calamity, 2017-07-14 02:39:28]

lgtm

[tsergeant, 2017-07-14 02:52:41]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-07-14 02:52:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 04:49:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1500000761454800,
"parent_rev": "7843a8afd9056bd3d2d89ca52e0077a11c5fef8d", "commit_rev":
"6f378a964c7e98b152f717263a2de31a16a340b5"}

[commit-bot: I haz the power, 2017-07-14 04:50:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1500000761454800,
"parent_rev": "1674a85c4268a152fbf405b97e1c3082f8ec389f", "commit_rev":
"d16c95a41c56a1b7b78a786347a3eb6a3bb06ef8"}

[commit-bot: I haz the power, 2017-07-14 04:50:15]

Description was changed from

==========
MD Bookmarks: Add 'show in folder' command to search result context menu

BUG=727174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Add 'show in folder' command to search result context menu

BUG=727174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2962283002
Cr-Commit-Position: refs/heads/master@{#486678}
Committed:
https://chromium.googlesource.com/chromium/src/+/d16c95a41c56a1b7b78a786347a3...
==========

[commit-bot: I haz the power, 2017-07-14 04:50:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d16c95a41c56a1b7b78a786347a3...