Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 2962273002: Revert of Added a system caret used for accessibility on Windows. (Closed)

Created:
3 years, 5 months ago by Timothy Loh
Modified:
3 years, 5 months ago
CC:
aboxhall+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, tfarina, yusukes+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added a system caret used for accessibility on Windows. (patchset #28 id:540001 of https://codereview.chromium.org/2852763002/ ) Reason for revert: The added test AXSystemCaretWinTest.TestMovingWindow is failing on the bots, e.g. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61190 Original issue's description: > Added a system caret used for accessibility on Windows. > > Screen magnifiers need to know where the caret is located so that they can show a magnified caret allowing the user to more easily track it. > Existing screen magnifiers, such as the built-in Windows Magnifier, require a system caret to be present in order to track it. However, Chrome doesn't use the system caret. > This is an object that implements the same accessibility interface that would have been returned by the system if the system caret had been used. > R=dmazzoni@chromium.org, shuchen@chromium.org, ellyjones@chromium.org, ananta@chromium.org, sky@chromium.org, sadrul@chromium.org > > Review-Url: https://codereview.chromium.org/2852763002 > Cr-Commit-Position: refs/heads/master@{#483558} > Committed: https://chromium.googlesource.com/chromium/src/+/3fc0df1e01ab7e17318ce50724890f939bc00fa4 TBR=ananta@chromium.org,dmazzoni@chromium.org,ellyjones@chromium.org,sadrul@chromium.org,shuchen@chromium.org,sky@chromium.org,nektar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2962273002 Cr-Commit-Position: refs/heads/master@{#483611} Committed: https://chromium.googlesource.com/chromium/src/+/8620053cfda9ac0f2dd0c2e0231231ccb5033fe9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -474 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M ui/accessibility/BUILD.gn View 5 chunks +2 lines, -5 lines 0 comments Download
A ui/accessibility/platform/ax_fake_caret_win.h View 1 chunk +60 lines, -0 lines 0 comments Download
A ui/accessibility/platform/ax_fake_caret_win.cc View 1 chunk +111 lines, -0 lines 0 comments Download
D ui/accessibility/platform/ax_system_caret_win.h View 1 chunk +0 lines, -60 lines 0 comments Download
D ui/accessibility/platform/ax_system_caret_win.cc View 1 chunk +0 lines, -115 lines 0 comments Download
M ui/base/ime/input_method_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/input_method_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/accessibility/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D ui/views/accessibility/ax_system_caret_win_interactive_uitest.cc View 1 chunk +0 lines, -169 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 2 chunks +1 line, -6 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/win/hwnd_message_handler.h View 6 chunks +3 lines, -24 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 8 chunks +2 lines, -62 lines 0 comments Download
M ui/views/win/hwnd_message_handler_delegate.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Timothy Loh
Created Revert of Added a system caret used for accessibility on Windows.
3 years, 5 months ago (2017-06-30 03:08:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962273002/1
3 years, 5 months ago (2017-06-30 03:08:37 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 03:09:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8620053cfda9ac0f2dd0c2e02312...

Powered by Google App Engine
This is Rietveld 408576698