Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Issue 2962243002: Move CollectInlinesInternal to anonymous namespace (Closed)

Created:
3 years, 5 months ago by Xiaocheng
Modified:
3 years, 5 months ago
Reviewers:
eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, lchoi+reviews_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CollectInlinesInternal to anonymous namespace This is a follow-up patch of crrev.com/2965573003, moving the local function to the anonymous namespace. BUG=699017 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2962243002 Cr-Commit-Position: refs/heads/master@{#483828} Committed: https://chromium.googlesource.com/chromium/src/+/cd18a26eb800d22aa951c00f42f67d98db3c8b15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -51 lines) Patch
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc View 2 chunks +46 lines, -51 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
Xiaocheng
PTAL. It seems that git diff can't handle such code moving correctly... Is there any ...
3 years, 5 months ago (2017-06-30 00:26:29 UTC) #4
eae
LGTM
3 years, 5 months ago (2017-06-30 17:16:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962243002/1
3 years, 5 months ago (2017-06-30 17:16:30 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 21:26:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd18a26eb800d22aa951c00f42f6...

Powered by Google App Engine
This is Rietveld 408576698