Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2962203002: Replace a DCHECK with a return false, when processing invalid stop waiting data. (Closed)

Created:
3 years, 5 months ago by Ryan Hamilton
Modified:
3 years, 5 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace a DCHECK with a return false, when processing invalid stop waiting data. Merge internal change: 160571176 BUG=736367 Review-Url: https://codereview.chromium.org/2962203002 Cr-Commit-Position: refs/heads/master@{#483487} Committed: https://chromium.googlesource.com/chromium/src/+/505b8e62281ad25172bfa025bbd546ec8a3c955c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M net/quic/core/quic_framer.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/core/quic_framer_test.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Ryan Hamilton
3 years, 5 months ago (2017-06-29 18:47:10 UTC) #2
Zhongyi Shi
lgtm!
3 years, 5 months ago (2017-06-29 19:13:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962203002/1
3 years, 5 months ago (2017-06-29 21:12:13 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 21:16:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/505b8e62281ad25172bfa025bbd5...

Powered by Google App Engine
This is Rietveld 408576698