Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2962103002: MD History: Fix text selection in history items (Closed)

Created:
3 years, 5 months ago by tsergeant
Modified:
3 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix text selection in history items Clicking on a history item would immediately change focus if the item wasn't selected, preventing selection with the mouse. This fixes the issue by preventing the extra unnecessary change of focus. BUG=675058 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2962103002 Cr-Commit-Position: refs/heads/master@{#483632} Committed: https://chromium.googlesource.com/chromium/src/+/896d42e807efa7b168487deb1e2b530de715cdaa

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/resources/md_history/history_item.js View 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
tsergeant
3 years, 5 months ago (2017-06-29 03:59:22 UTC) #9
calamity
lgtm
3 years, 5 months ago (2017-06-30 03:25:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962103002/40001
3 years, 5 months ago (2017-06-30 03:33:40 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 04:49:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/896d42e807efa7b168487deb1e2b...

Powered by Google App Engine
This is Rietveld 408576698