Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: content/shell/common/shell_messages.h

Issue 2962073002: OOPIF support for layout test pixel dumps.
Patch Set: Rebasing on top of 8bc8e844008b (still works locally). Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/common/layout_test.mojom ('k') | content/shell/renderer/layout_test/blink_test_runner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/common/shell_messages.h
diff --git a/content/shell/common/shell_messages.h b/content/shell/common/shell_messages.h
index db671cd895c8ca9a40562e734c386975a581ec8a..295fe31f18140bd9c3355a8664b993d140aeecbe 100644
--- a/content/shell/common/shell_messages.h
+++ b/content/shell/common/shell_messages.h
@@ -46,6 +46,11 @@ IPC_MESSAGE_ROUTED0(ShellViewMsg_TryLeakDetection)
IPC_MESSAGE_ROUTED1(ShellViewMsg_LayoutDumpCompleted,
std::string /* completed/stitched layout dump */)
+// Notifies BlinkTestRunner that the pixel dump has completed
+// (and that it can proceed with finishing up the test).
+IPC_MESSAGE_ROUTED1(ShellViewMsg_PixelsDumpResult,
+ SkBitmap /* completed/stitched pixel dump */)
+
// Send a text dump of the WebContents to the render host.
IPC_MESSAGE_ROUTED1(ShellViewHostMsg_TextDump,
std::string /* dump */)
@@ -56,6 +61,12 @@ IPC_MESSAGE_ROUTED1(ShellViewHostMsg_TextDump,
// ShellViewMsg_LayoutDumpCompleted.
IPC_MESSAGE_ROUTED0(ShellViewHostMsg_InitiateLayoutDump)
+// Asks the browser process to perform a pixel dump spanning all the
+// (potentially cross-process) frames. This goes through multiple
+// LayoutTestControl.SnapshotFrameImag calls and ends with sending of
+// ShellViewMsg_PixelsDumpCompleted.
+IPC_MESSAGE_ROUTED0(ShellViewHostMsg_InitiatePixelsDump)
+
// Send an image dump of the WebContents to the render host.
IPC_MESSAGE_ROUTED2(ShellViewHostMsg_ImageDump,
std::string /* actual pixel hash */,
« no previous file with comments | « content/shell/common/layout_test.mojom ('k') | content/shell/renderer/layout_test/blink_test_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698