Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.h

Issue 2962073002: OOPIF support for layout test pixel dumps.
Patch Set: Rebasing on top of 8bc8e844008b (still works locally). Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/common/shell_messages.h ('k') | content/shell/renderer/layout_test/blink_test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/layout_test/blink_test_runner.h
diff --git a/content/shell/renderer/layout_test/blink_test_runner.h b/content/shell/renderer/layout_test/blink_test_runner.h
index 22c3f7189604940acf4234e41c7a40d95b4b4083..33dff68ce235bbb50c2e8025c307b7362f049182 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.h
+++ b/content/shell/renderer/layout_test/blink_test_runner.h
@@ -163,6 +163,8 @@ class BlinkTestRunner : public RenderViewObserver,
void ForceTextInputStateUpdate(blink::WebLocalFrame* frame) override;
bool IsNavigationInitiatedByRenderer(
const blink::WebURLRequest& request) override;
+ void DumpPixelsAsync(
+ base::OnceCallback<void(const SkBitmap&)> callback) override;
// Resets a RenderView to a known state for layout tests. It is used both when
// a RenderView is created and when reusing an existing RenderView for the
@@ -189,6 +191,7 @@ class BlinkTestRunner : public RenderViewObserver,
void OnTryLeakDetection();
void OnReplyBluetoothManualChooserEvents(
const std::vector<std::string>& events);
+ void OnPixelsDumpResult(const SkBitmap& result);
// RenderViewObserver implementation.
void OnDestruct() override;
@@ -223,6 +226,8 @@ class BlinkTestRunner : public RenderViewObserver,
std::unique_ptr<test_runner::AppBannerService> app_banner_service_;
+ base::OnceCallback<void(const SkBitmap&)> pixels_dump_callback_;
+
std::unique_ptr<LeakDetector> leak_detector_;
DISALLOW_COPY_AND_ASSIGN(BlinkTestRunner);
« no previous file with comments | « content/shell/common/shell_messages.h ('k') | content/shell/renderer/layout_test/blink_test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698