Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 2962073002: OOPIF support for layout test pixel dumps.

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

OOPIF support for layout test pixel dumps. This CL moves gathering of pixel dumps for layout tests from the renderer process to the browser process. This move helps ensure that pixel dumps are OOPIF-friendly. DO NOT SUBMIT: There are still quite a few unsolved issues in this CL: 1. kDisableThreadedCompositing 2. TestLayerTreeFrameSink (needed for pixel_dump.cc) This is a potential big clean-up / code deletion opportunity here. 3. 10-seconds delay 4. Some pixel dumps need to stay in the renderer process (is_printing + dump_selection_rect) BUG=667551 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : PoC that works fine via threaded compositing, but I hear that threaded compositing is undesirable for layout tests. #

Patch Set 3 : All-white page :-( when threaded compositing is disabled. #

Patch Set 4 : Pixel dumps work with OOPIFs, buts lots of work remains before this CL can be landed. #

Patch Set 5 : Still works... #

Patch Set 6 : Rebasing on top of 8bc8e844008b (still works locally). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -96 lines) Patch
M content/renderer/layout_test_dependencies.h View 1 2 3 4 1 chunk +4 lines, -16 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 1 chunk +0 lines, -7 lines 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.h View 1 2 3 4 3 chunks +11 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.cc View 1 2 3 4 3 chunks +82 lines, -0 lines 0 comments Download
M content/shell/common/layout_test.mojom View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/common/shell_messages.h View 1 2 3 4 2 chunks +11 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 2 3 4 3 chunks +5 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_frame_observer.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_frame_observer.cc View 1 2 2 chunks +47 lines, -0 lines 0 comments Download
M content/shell/test_runner/test_runner.cc View 1 2 3 4 2 chunks +9 lines, -4 lines 0 comments Download
M content/shell/test_runner/web_test_delegate.h View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 1 2 3 4 5 4 chunks +6 lines, -61 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/cross-site-frame.html View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/cross-site-frame-expected.html View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/resources/frame.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M ui/gfx/font_render_params.cc View 1 2 3 4 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (10 generated)
Łukasz Anforowicz
Description was changed from ========== OOPIF support for layout test pixel dumps. This CL moves ...
3 years, 5 months ago (2017-07-10 16:44:09 UTC) #1
Łukasz Anforowicz
Description was changed from ========== OOPIF support for layout test pixel dumps. This CL moves ...
3 years, 5 months ago (2017-07-10 16:44:11 UTC) #2
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-12 22:17:25 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962073002/80001
3 years, 5 months ago (2017-07-12 22:17:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-12 22:21:14 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/461885)
3 years, 5 months ago (2017-07-12 22:21:16 UTC) #6
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-12 22:51:10 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962073002/100001
3 years, 5 months ago (2017-07-12 22:51:26 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-12 23:00:24 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 23:00:25 UTC) #10
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698