Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2961993002: [dart:io] Fixes a crash in VM shutdown when signals are watched (Closed)

Created:
3 years, 5 months ago by zra
Modified:
3 years, 5 months ago
Reviewers:
bkonyi, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[dart:io] Fixes a crash in VM shutdown when signals are watched This CL fixes a crash in VM shutdown which is triggered by Dart programs that throw unhandled exceptions while watching OS signals. fixes #30033 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/4ecf748d5e05365c383c06de9ff49b937d6ba42e

Patch Set 1 #

Patch Set 2 : Fixes for Windows, comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -25 lines) Patch
M runtime/bin/process.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M runtime/bin/process.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/process_android.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/bin/process_linux.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/bin/process_macos.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/bin/process_win.cc View 2 chunks +19 lines, -16 lines 0 comments Download
A tests/standalone/io/signals_exception_test.dart View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 5 months ago (2017-06-28 15:54:22 UTC) #2
rmacnak
lgtm w/ new issue about shutdown leak
3 years, 5 months ago (2017-06-28 17:32:48 UTC) #3
zra
Filed: https://github.com/dart-lang/sdk/issues/30042
3 years, 5 months ago (2017-06-28 18:02:39 UTC) #4
zra
3 years, 5 months ago (2017-06-28 18:05:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4ecf748d5e05365c383c06de9ff49b937d6ba42e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698