Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: runtime/bin/process.cc

Issue 2961993002: [dart:io] Fixes a crash in VM shutdown when signals are watched (Closed)
Patch Set: Fixes for Windows, comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/process.h ('k') | runtime/bin/process_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process.cc
diff --git a/runtime/bin/process.cc b/runtime/bin/process.cc
index ab2b9ace9d46b0dda925f0aa0d5531b430b64120..ce8c82247f85e10cea74ab0a118180af21cb2ea7 100644
--- a/runtime/bin/process.cc
+++ b/runtime/bin/process.cc
@@ -75,7 +75,7 @@ static char** ExtractCStringList(Dart_Handle strings,
void Process::ClearAllSignalHandlers() {
for (intptr_t i = 1; i <= kLastSignal; i++) {
- ClearSignalHandler(i);
+ ClearSignalHandler(i, ILLEGAL_PORT);
}
}
@@ -301,7 +301,7 @@ void FUNCTION_NAME(Process_SetSignalHandler)(Dart_NativeArguments args) {
void FUNCTION_NAME(Process_ClearSignalHandler)(Dart_NativeArguments args) {
intptr_t signal = DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 0));
- Process::ClearSignalHandler(signal);
+ Process::ClearSignalHandler(signal, Dart_GetMainPortId());
}
« no previous file with comments | « runtime/bin/process.h ('k') | runtime/bin/process_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698