Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: ui/app_list/app_list_features.cc

Issue 2961923002: Use EnablePlayStoreAppSearch feature flag. (Closed)
Patch Set: Oshima's comment. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/app_list/app_list_features.h ('k') | ui/app_list/views/search_result_tile_item_list_view.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/app_list/app_list_features.h" 5 #include "ui/app_list/app_list_features.h"
6 6
7 #include "base/feature_list.h" 7 #include "base/feature_list.h"
8 #include "base/metrics/field_trial_params.h" 8 #include "base/metrics/field_trial_params.h"
9 9
10 namespace app_list { 10 namespace app_list {
11 namespace features { 11 namespace features {
12 12
13 const base::Feature kEnableAnswerCard{"EnableAnswerCard", 13 const base::Feature kEnableAnswerCard{"EnableAnswerCard",
14 base::FEATURE_DISABLED_BY_DEFAULT}; 14 base::FEATURE_DISABLED_BY_DEFAULT};
15 const base::Feature kEnableAnswerCardDarkRun{"EnableAnswerCardDarkRun", 15 const base::Feature kEnableAnswerCardDarkRun{"EnableAnswerCardDarkRun",
16 base::FEATURE_DISABLED_BY_DEFAULT}; 16 base::FEATURE_DISABLED_BY_DEFAULT};
17 const base::Feature kEnableFullscreenAppList{"EnableFullscreenAppList", 17 const base::Feature kEnableFullscreenAppList{"EnableFullscreenAppList",
18 base::FEATURE_DISABLED_BY_DEFAULT}; 18 base::FEATURE_DISABLED_BY_DEFAULT};
19 const base::Feature kEnablePlaystoreAppSearch{ 19 const base::Feature kEnablePlayStoreAppSearch{
20 "EnablePlaystoreAppSearch", base::FEATURE_DISABLED_BY_DEFAULT}; 20 "EnablePlayStoreAppSearch", base::FEATURE_DISABLED_BY_DEFAULT};
21 21
22 bool IsAnswerCardEnabled() { 22 bool IsAnswerCardEnabled() {
23 static const bool enabled = base::FeatureList::IsEnabled(kEnableAnswerCard); 23 static const bool enabled = base::FeatureList::IsEnabled(kEnableAnswerCard);
24 return enabled; 24 return enabled;
25 } 25 }
26 26
27 bool IsAnswerCardDarkRunEnabled() { 27 bool IsAnswerCardDarkRunEnabled() {
28 static const bool enabled = 28 static const bool enabled =
29 base::FeatureList::IsEnabled(kEnableAnswerCardDarkRun); 29 base::FeatureList::IsEnabled(kEnableAnswerCardDarkRun);
30 return enabled; 30 return enabled;
31 } 31 }
32 32
33 bool IsFullscreenAppListEnabled() { 33 bool IsFullscreenAppListEnabled() {
34 // Not using local static variable to allow tests to change this value. 34 // Not using local static variable to allow tests to change this value.
35 return base::FeatureList::IsEnabled(kEnableFullscreenAppList); 35 return base::FeatureList::IsEnabled(kEnableFullscreenAppList);
36 } 36 }
37 37
38 bool IsSearchResultsNewDesignEnabled() { 38 bool IsSearchResultsNewDesignEnabled() {
39 return IsFullscreenAppListEnabled() || 39 return IsFullscreenAppListEnabled() ||
40 (IsAnswerCardEnabled() && !IsAnswerCardDarkRunEnabled()); 40 (IsAnswerCardEnabled() && !IsAnswerCardDarkRunEnabled());
41 } 41 }
42 42
43 bool IsPlaystoreAppSearchEnabled() { 43 bool IsPlayStoreAppSearchEnabled() {
44 static const bool enabled = 44 static const bool enabled =
45 base::FeatureList::IsEnabled(kEnablePlaystoreAppSearch); 45 base::FeatureList::IsEnabled(kEnablePlayStoreAppSearch);
46 return enabled; 46 return enabled;
47 } 47 }
48 48
49 int AnswerCardMaxWidth() { 49 int AnswerCardMaxWidth() {
50 static const int max_width = base::GetFieldTrialParamByFeatureAsInt( 50 static const int max_width = base::GetFieldTrialParamByFeatureAsInt(
51 kEnableAnswerCard, "CardMaxWidth", 608); 51 kEnableAnswerCard, "CardMaxWidth", 608);
52 return max_width; 52 return max_width;
53 } 53 }
54 54
55 int AnswerCardMaxHeight() { 55 int AnswerCardMaxHeight() {
56 static const int max_height = base::GetFieldTrialParamByFeatureAsInt( 56 static const int max_height = base::GetFieldTrialParamByFeatureAsInt(
57 kEnableAnswerCard, "CardMaxHeight", 266); 57 kEnableAnswerCard, "CardMaxHeight", 266);
58 return max_height; 58 return max_height;
59 } 59 }
60 60
61 std::string AnswerServerUrl() { 61 std::string AnswerServerUrl() {
62 return base::GetFieldTrialParamValueByFeature(kEnableAnswerCard, "ServerUrl"); 62 return base::GetFieldTrialParamValueByFeature(kEnableAnswerCard, "ServerUrl");
63 } 63 }
64 64
65 } // namespace features 65 } // namespace features
66 } // namespace app_list 66 } // namespace app_list
OLDNEW
« no previous file with comments | « ui/app_list/app_list_features.h ('k') | ui/app_list/views/search_result_tile_item_list_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698