Use EnablePlayStoreAppSearch feature flag.

Use EnablePlayStoreAppSearch feature flag.

We apply EnablePlayStoreAppSearch to decide whether to:

- search for uninstalled apps from Play Store;
- show a proper badge in the Play Store app result;
- show the review score and price of every searched app.

Currently using the IsFullscreenAppListEnabled flag is incorrect.

BUG=736552
Review-Url: https://codereview.chromium.org/2961923002
Cr-Commit-Position: refs/heads/master@{#485454}
Committed: https://chromium.googlesource.com/chromium/src/+/0f8982efb8c8db9ef3aae23443b6f8b3b732df17

[Jiaquan He, 2017-06-27 23:14:12]

Description was changed from

==========
Use EnablePlaystoreAppSearch feature flag.

We apply EnablePlaystoreAppSearch whether to:

- search for uninstalled apps from Play Store;
- show a proper badge in the Play Store app result;
- show the review score and price of every searched app.

Currently using the IsFullscreenAppListEnabled flag is incorrect.

BUG=736552
==========

to

==========
Use EnablePlayStoreAppSearch feature flag.

We apply EnablePlayStoreAppSearch whether to:

- search for uninstalled apps from Play Store;
- show a proper badge in the Play Store app result;
- show the review score and price of every searched app.

Currently using the IsFullscreenAppListEnabled flag is incorrect.

BUG=736552
==========

[Jiaquan He, 2017-06-27 23:14:12]

hejq@chromium.org changed reviewers:
+ warx@chromium.org, weidongg@chromium.org, xiyuan@chromium.org

[Jiaquan He, 2017-06-27 23:14:50]

Description was changed from

==========
Use EnablePlayStoreAppSearch feature flag.

We apply EnablePlayStoreAppSearch whether to:

- search for uninstalled apps from Play Store;
- show a proper badge in the Play Store app result;
- show the review score and price of every searched app.

Currently using the IsFullscreenAppListEnabled flag is incorrect.

BUG=736552
==========

to

==========
Use EnablePlayStoreAppSearch feature flag.

We apply EnablePlayStoreAppSearch to decide whether to:

- search for uninstalled apps from Play Store;
- show a proper badge in the Play Store app result;
- show the review score and price of every searched app.

Currently using the IsFullscreenAppListEnabled flag is incorrect.

BUG=736552
==========

[Jiaquan He, 2017-06-28 22:08:35]

The CQ bit was checked by hejq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 22:09:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 23:35:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 23:35:18]

Dry run: This issue passed the CQ dry run.

[Jiaquan He, 2017-07-05 19:15:39]

hejq@chromium.org changed reviewers:
+ oshima@chromium.org

[Jiaquan He, 2017-07-05 21:43:53]

Hi Xiyuan and Oshima, PTAL.

[oshima, 2017-07-07 23:59:57]

lgtm with a nit

https://codereview.chromium.org/2961923002/diff/20001/ui/app_list/views/tile_...
File ui/app_list/views/tile_item_view.h (right):

https://codereview.chromium.org/2961923002/diff/20001/ui/app_list/views/tile_...
ui/app_list/views/tile_item_view.h:9: #include <utility>
do you need utility here?

[Jiaquan He, 2017-07-08 00:43:56]

Question.

https://codereview.chromium.org/2961923002/diff/20001/ui/app_list/views/tile_...
File ui/app_list/views/tile_item_view.h (right):

https://codereview.chromium.org/2961923002/diff/20001/ui/app_list/views/tile_...
ui/app_list/views/tile_item_view.h:9: #include <utility>
On 2017/07/07 23:59:56, oshima wrote:
> do you need utility here?

The lint check tells me to include utility, but actually it's not needed.
Should I keep it or remove in such case?

[oshima, 2017-07-08 00:47:15]

https://codereview.chromium.org/2961923002/diff/20001/ui/app_list/views/tile_...
File ui/app_list/views/tile_item_view.h (right):

https://codereview.chromium.org/2961923002/diff/20001/ui/app_list/views/tile_...
ui/app_list/views/tile_item_view.h:9: #include <utility>
On 2017/07/08 00:43:55, Jiaquan He wrote:
> On 2017/07/07 23:59:56, oshima wrote:
> > do you need utility here?
> 
> The lint check tells me to include utility, but actually it's not needed.
> Should I keep it or remove in such case?

Will voving to .cc file fix it?

[Jiaquan He, 2017-07-08 01:24:47]

https://codereview.chromium.org/2961923002/diff/20001/ui/app_list/views/tile_...
File ui/app_list/views/tile_item_view.h (right):

https://codereview.chromium.org/2961923002/diff/20001/ui/app_list/views/tile_...
ui/app_list/views/tile_item_view.h:9: #include <utility>
On 2017/07/08 00:47:15, oshima wrote:
> On 2017/07/08 00:43:55, Jiaquan He wrote:
> > On 2017/07/07 23:59:56, oshima wrote:
> > > do you need utility here?
> > 
> > The lint check tells me to include utility, but actually it's not needed.
> > Should I keep it or remove in such case?
> 
> Will voving to .cc file fix it?

Makes sense. It fixes!

[Jiaquan He, 2017-07-08 01:26:11]

The CQ bit was checked by hejq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-08 01:26:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-08 02:01:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-08 02:01:16]

Dry run: This issue passed the CQ dry run.

[Jiaquan He, 2017-07-08 16:31:08]

The CQ bit was checked by hejq@chromium.org

[Jiaquan He, 2017-07-08 16:31:09]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2961923002/#ps40001
(title: "Oshima's comment.")

[commit-bot: I haz the power, 2017-07-08 16:31:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-08 16:39:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-08 16:39:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oshima, 2017-07-10 16:38:47]

On 2017/07/08 16:39:35, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

You need approval from app list owners.

[Jiaquan He, 2017-07-10 17:28:15]

hejq@chromium.org changed reviewers:
+ jennyz@chromium.org

[Jiaquan He, 2017-07-10 17:29:16]

Thank you Oshima!

Hi Jenny, could you have a look at this CL since Xiyuan is OOO?

[jennyz, 2017-07-10 22:52:14]

lgtm

[Jiaquan He, 2017-07-10 23:27:23]

The CQ bit was checked by hejq@chromium.org

[commit-bot: I haz the power, 2017-07-10 23:27:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 00:12:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499729243568130,
"parent_rev": "efac3d1c9b2f05ffe6eeca1b6040d605f792bdaa", "commit_rev":
"0f8982efb8c8db9ef3aae23443b6f8b3b732df17"}

[commit-bot: I haz the power, 2017-07-11 00:12:16]

Description was changed from

==========
Use EnablePlayStoreAppSearch feature flag.

We apply EnablePlayStoreAppSearch to decide whether to:

- search for uninstalled apps from Play Store;
- show a proper badge in the Play Store app result;
- show the review score and price of every searched app.

Currently using the IsFullscreenAppListEnabled flag is incorrect.

BUG=736552
==========

to

==========
Use EnablePlayStoreAppSearch feature flag.

We apply EnablePlayStoreAppSearch to decide whether to:

- search for uninstalled apps from Play Store;
- show a proper badge in the Play Store app result;
- show the review score and price of every searched app.

Currently using the IsFullscreenAppListEnabled flag is incorrect.

BUG=736552

Review-Url: https://codereview.chromium.org/2961923002
Cr-Commit-Position: refs/heads/master@{#485454}
Committed:
https://chromium.googlesource.com/chromium/src/+/0f8982efb8c8db9ef3aae23443b6...
==========

[commit-bot: I haz the power, 2017-07-11 00:12:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0f8982efb8c8db9ef3aae23443b6...