Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2961913002: Fire load complete notifications on Mac even when page loads quickly. (Closed)

Created:
3 years, 5 months ago by dmazzoni
Modified:
3 years, 5 months ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, aleventhal+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, mac-reviews_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fire load complete notifications on Mac even when page loads quickly. This broke with change r477889 (https://codereview.chromium.org/2917363002) because it fired load complete notifications when the "loaded" flag changes from false to true, but it failed to handle cases where we swap in a new tree root that's already loaded, which happens with local pages and data urls. BUG=733334, 699438 Review-Url: https://codereview.chromium.org/2961913002 Cr-Commit-Position: refs/heads/master@{#482818} Committed: https://chromium.googlesource.com/chromium/src/+/1a48b88399b0324a2cc828db06f375c9ed3a777c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dmazzoni
3 years, 5 months ago (2017-06-27 23:04:55 UTC) #3
nektarios
lgtm
3 years, 5 months ago (2017-06-28 00:27:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961913002/1
3 years, 5 months ago (2017-06-28 00:28:15 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 00:33:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a48b88399b0324a2cc828db06f3...

Powered by Google App Engine
This is Rietveld 408576698