Issue 2961863003: fix #29733, handle variables that completely shadow parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2961863003: fix #29733, handle variables that completely shadow parameters (Closed)

Created:
3 years, 5 months ago by Jennifer Messerly

Modified:
3 years, 5 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -48 lines)			Patch
M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View	14 chunks	+36 lines, -37 lines	0 comments	Download
M	pkg/dev_compiler/lib/src/js_ast/nodes.dart	View	2 chunks	+1 line, -11 lines	0 comments	Download
A	tests/language_strong/shadow_parameter_and_local_test.dart	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

This also has some cleanups, in particular _visitList.

3 years, 5 months ago (2017-06-27 23:44:46 UTC) #2

Jennifer Messerly

3 years, 5 months ago (2017-06-29 17:39:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
94af6bf093ee71f1bff25a44fbdc95845619682a (presubmit successful).