Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: pkg/dev_compiler/lib/src/js_ast/nodes.dart

Issue 2961863003: fix #29733, handle variables that completely shadow parameters (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/lib/src/js_ast/nodes.dart
diff --git a/pkg/dev_compiler/lib/src/js_ast/nodes.dart b/pkg/dev_compiler/lib/src/js_ast/nodes.dart
index 29aa1b50ffd19aa94e116c088242c78a407d0960..354e4f69115119211e029b41d5fc04cc0216e2b4 100644
--- a/pkg/dev_compiler/lib/src/js_ast/nodes.dart
+++ b/pkg/dev_compiler/lib/src/js_ast/nodes.dart
@@ -252,10 +252,8 @@ abstract class Node {
/// setting this after construction.
Object sourceInformation;
- ClosureAnnotation _closureAnnotation;
-
/// Closure annotation of this node.
- ClosureAnnotation get closureAnnotation => _closureAnnotation;
+ ClosureAnnotation closureAnnotation;
accept(NodeVisitor visitor);
void visitChildren(NodeVisitor visitor);
@@ -264,14 +262,6 @@ abstract class Node {
// private method is create a copy with a new position.
Node _clone();
- withClosureAnnotation(ClosureAnnotation closureAnnotation) {
- if (this.closureAnnotation == closureAnnotation) return this;
-
- return _clone()
- ..sourceInformation = sourceInformation
- .._closureAnnotation = closureAnnotation;
- }
-
// Returns a node equivalent to [this], but with new source position and end
// source position.
Node withSourceInformation(sourceInformation) {
« no previous file with comments | « pkg/dev_compiler/lib/src/compiler/code_generator.dart ('k') | tests/language_strong/shadow_parameter_and_local_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698