[sync] Fix IsSyncConfirmationNeeded crash when local backend is enabled

[sync] Fix IsSyncConfirmationNeeded crash when local backend is enabled

signin_ isn't present when local backend is enabled, so we need to avoid
dereferencing it. Other call sites for IsSignedIn() do this check
already.

R=skym@chromium.org
BUG=736118, 736241
Review-Url: https://codereview.chromium.org/2961673002
Cr-Commit-Position: refs/heads/master@{#482419}
Committed: https://chromium.googlesource.com/chromium/src/+/09fba90138a1c3197d0568fec12ceb75217aedf3

[Patrick Noland, 2017-06-26 19:12:06]

The CQ bit was checked by pnoland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 19:12:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 19:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 19:36:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Patrick Noland, 2017-06-26 20:25:02]

The CQ bit was checked by pnoland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 20:25:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patrick Noland, 2017-06-26 20:51:58]

PTAL

[Patrick Noland, 2017-06-26 21:20:18]

Description was changed from

==========
[sync] Fix IsSyncConfirmationNeeded crash when local backend is enabled

signin_ isn't present when local backend is enabled, so we need to avoid
dereferencing it. Other call sites for IsSignedIn() do this check
already.

R=skym@chromium.org
BUG=73611,736241
==========

to

==========
[sync] Fix IsSyncConfirmationNeeded crash when local backend is enabled

signin_ isn't present when local backend is enabled, so we need to avoid
dereferencing it. Other call sites for IsSignedIn() do this check
already.

R=skym@chromium.org
BUG=736118,736241
==========

[skym, 2017-06-26 21:21:05]

lgtm

[commit-bot: I haz the power, 2017-06-26 21:33:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 21:33:51]

Dry run: This issue passed the CQ dry run.

[Patrick Noland, 2017-06-26 21:34:02]

The CQ bit was checked by pnoland@chromium.org

[commit-bot: I haz the power, 2017-06-26 21:34:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 21:38:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498512842600620,
"parent_rev": "a7ac5d97093331a18c69d16a2ebe82bde507c1bd", "commit_rev":
"09fba90138a1c3197d0568fec12ceb75217aedf3"}

[commit-bot: I haz the power, 2017-06-26 21:38:41]

Description was changed from

==========
[sync] Fix IsSyncConfirmationNeeded crash when local backend is enabled

signin_ isn't present when local backend is enabled, so we need to avoid
dereferencing it. Other call sites for IsSignedIn() do this check
already.

R=skym@chromium.org
BUG=736118,736241
==========

to

==========
[sync] Fix IsSyncConfirmationNeeded crash when local backend is enabled

signin_ isn't present when local backend is enabled, so we need to avoid
dereferencing it. Other call sites for IsSignedIn() do this check
already.

R=skym@chromium.org
BUG=736118,736241

Review-Url: https://codereview.chromium.org/2961673002
Cr-Commit-Position: refs/heads/master@{#482419}
Committed:
https://chromium.googlesource.com/chromium/src/+/09fba90138a1c3197d0568fec12c...
==========

[commit-bot: I haz the power, 2017-06-26 21:38:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/09fba90138a1c3197d0568fec12c...