Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2961663004: [merge to 3141] Revert "Create ServiceWorkerProviderHost before starting worker" (Closed)

Created:
3 years, 5 months ago by shimazu
Modified:
3 years, 5 months ago
Reviewers:
falken, kinuko, dcheng
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3141
Project:
chromium
Visibility:
Public.

Description

[merge to 3141] Revert "Create ServiceWorkerProviderHost before starting worker" This reverts commit 1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f. Reason: This patch is reverted due to crashes. See also the bug: https://crbug.com/736649 BUG=629701, 676983, 668633, 736649 TBR=falken@chromium.org, kinuko@chromium.org, dcheng@chromium.org Review-Url: https://codereview.chromium.org/2958753003 Cr-Original-Commit-Position: refs/heads/master@{#482602} Review-Url: https://codereview.chromium.org/2961663004 . Cr-Commit-Position: refs/branch-heads/3141@{#10} Cr-Branched-From: 180095eb1bca7df1cdcb02547340499c2ee3af6e-refs/heads/master@{#482153} Committed: https://chromium.googlesource.com/chromium/src/+/99262d9db8c1264f97a1727b3100167a50315494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -743 lines) Patch
M content/browser/background_sync/background_sync_manager_unittest.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M content/browser/payments/payment_app_content_unittest_base.cc View 4 chunks +10 lines, -34 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.h View 5 chunks +3 lines, -15 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 7 chunks +15 lines, -11 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 24 chunks +32 lines, -74 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 7 chunks +9 lines, -8 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 9 chunks +20 lines, -16 lines 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler_unittest.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M content/browser/service_worker/link_header_support_unittest.cc View 1 chunk +12 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 8 chunks +20 lines, -37 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 5 chunks +12 lines, -18 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 4 chunks +90 lines, -14 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 5 chunks +72 lines, -24 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 10 chunks +34 lines, -119 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 6 chunks +14 lines, -35 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 6 chunks +29 lines, -90 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_registration_handle.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_test_utils.h View 4 chunks +2 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_test_utils.cc View 3 chunks +7 lines, -18 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 4 chunks +9 lines, -13 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +0 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 4 chunks +1 line, -28 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 3 chunks +9 lines, -17 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 5 chunks +14 lines, -8 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.h View 2 chunks +4 lines, -5 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.cc View 3 chunks +10 lines, -20 lines 0 comments Download
M content/common/service_worker/embedded_worker.mojom View 3 chunks +6 lines, -5 lines 0 comments Download
M content/common/service_worker/service_worker.mojom View 1 chunk +8 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_provider.mojom View 1 chunk +0 lines, -14 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/service_worker/service_worker_types.mojom View 1 chunk +1 line, -12 lines 0 comments Download
M content/common/service_worker/service_worker_types.typemap View 1 chunk +3 lines, -9 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_instance_client_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_instance_client_impl.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 5 chunks +2 lines, -7 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 5 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
shimazu
3 years, 5 months ago (2017-06-27 12:58:54 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
99262d9db8c1264f97a1727b3100167a50315494.

Powered by Google App Engine
This is Rietveld 408576698