Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2961653003: Replace os.mkdir with os.makedirs (Closed)

Created:
3 years, 5 months ago by sadafm
Modified:
3 years, 5 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Replace os.mkdir with os.makedirs /b in SWARMING_BOT_DIR and /var/log/messages in LOGS_DIR might not exist. This will prevent os.mkdir from constructing the whole path, which will in turn prevent the bot from bootstrapping. BUG= Review-Url: https://codereview.chromium.org/2961653003 Committed: https://github.com/luci/luci-py/commit/c9559b5bc80032e1a8f548247bba44d3a0e872eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M appengine/gce-backend/agent/agent.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961653003/1
3 years, 5 months ago (2017-06-27 15:23:40 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-06-27 15:23:41 UTC) #6
Vadim Sh.
lgtm
3 years, 5 months ago (2017-06-27 18:26:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961653003/1
3 years, 5 months ago (2017-06-27 18:40:48 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 18:43:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/c9559b5bc80032e1a8f548247bba44d3a0e872eb

Powered by Google App Engine
This is Rietveld 408576698