Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2961653002: Fix browse:chrome:newtab story (Closed)

Created:
3 years, 5 months ago by ssid
Modified:
3 years, 5 months ago
Reviewers:
nednguyen, perezju
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix browse:chrome:newtab story The uiautomator does not give the right element IDs for new popup window. So, use the text to search for the button instead. BUG=735405 Review-Url: https://codereview.chromium.org/2961653002 Cr-Commit-Position: refs/heads/master@{#482362} Committed: https://chromium.googlesource.com/chromium/src/+/a2849be12be0a4b84f45dc9185019f93b1c317b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/page_sets/system_health/chrome_stories.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
ssid
+Ned ptal thanks.
3 years, 5 months ago (2017-06-26 18:18:16 UTC) #2
nednguyen
lgtm
3 years, 5 months ago (2017-06-26 18:18:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961653002/1
3 years, 5 months ago (2017-06-26 19:37:47 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 19:43:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2849be12be0a4b84f45dc918501...

Powered by Google App Engine
This is Rietveld 408576698