Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2961643002: Account for null Document Frame when parsing inert attribute (Closed)

Created:
3 years, 5 months ago by kenrb
Modified:
3 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Account for null Document Frame when parsing inert attribute The SetIsInert method was added to Frame objects in r481761, which is called when an inert attribute is parsed on an element within that frame. This CL removes the assumption that the current Document has a valid Frame pointer, because that is sometimes false, such is in a <template>. BUG=736608 Review-Url: https://codereview.chromium.org/2961643002 Cr-Commit-Position: refs/heads/master@{#482999} Committed: https://chromium.googlesource.com/chromium/src/+/c4570da4971280f5e012ced0a9d13167751035d1

Patch Set 1 #

Patch Set 2 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/html/crash-template-with-inert-attribute.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/html/crash-template-with-inert-attribute-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
kenrb
tkent@: PTAL?
3 years, 5 months ago (2017-06-26 18:26:39 UTC) #4
tkent
This CL needs a test.
3 years, 5 months ago (2017-06-26 22:29:56 UTC) #7
kenrb
Test added.
3 years, 5 months ago (2017-06-27 21:28:13 UTC) #10
tkent
lgtm
3 years, 5 months ago (2017-06-27 22:47:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961643002/20001
3 years, 5 months ago (2017-06-28 13:32:44 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 15:39:51 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c4570da4971280f5e012ced0a9d1...

Powered by Google App Engine
This is Rietveld 408576698