Try converting some tests over to using console_test_launcher.

Try converting some tests over to using console_test_launcher.

In general the console_test_launcher execution type is preferable to
the raw execution type because it configures the environment correctly
for the sanitizer runtimes. Without proper configuration, some
sanitizers (in particular UBSan) may not print a full stack trace.

These specific tests have been converted because they run on the
"CFI Linux Full" bot and the linux_chromium_cfi_rel_ng trybot,
which are configured with CFI enabled and with a diagnostic
configuration that uses the UBSan runtime to produce diagnostics
including stack traces.

None of these tests run on chromium.gpu, so they don't seem to need
direct GPU access. I'm not aware of any other reason why they would
need to use the raw execution type either.

I haven't audited every test suite, so it's possible that other test
suites could also be converted.

BUG=732652
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2961603003
Cr-Commit-Position: refs/heads/master@{#483514}
Committed: https://chromium.googlesource.com/chromium/src/+/9c98ed29555b35e3d3fcaa0e6fdeecbb87533dbc

[pcc1, 2017-06-26 23:02:52]

The CQ bit was checked by pcc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 23:03:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pcc1, 2017-06-26 23:03:54]

Description was changed from

==========
Try converting some tests over to using console_test_launcher.

None of these tests run on chromium.gpu, so they don't seem to need
direct GPU access. I'm not aware of any other reason why they would
need to use the raw execution type either.

BUG=732652
R=dpranke@chromium.org
==========

to

==========
Try converting some tests over to using console_test_launcher.

None of these tests run on chromium.gpu, so they don't seem to need
direct GPU access. I'm not aware of any other reason why they would
need to use the raw execution type either.

BUG=732652
R=dpranke@chromium.org
==========

[pcc1, 2017-06-26 23:03:54]

pcc@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-06-26 23:08:07]

Looks fine to me, but Dirk should review this.

[commit-bot: I haz the power, 2017-06-27 00:24:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 00:24:46]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-06-27 01:08:44]

Why/how did you pick the ones you did pick? Can you update the CL description to
list the affected bots and some reason for making these changes, i.e., why is
raw bad and console_test_launcher good?

[pcc1, 2017-06-27 01:46:23]

Description was changed from

==========
Try converting some tests over to using console_test_launcher.

None of these tests run on chromium.gpu, so they don't seem to need
direct GPU access. I'm not aware of any other reason why they would
need to use the raw execution type either.

BUG=732652
R=dpranke@chromium.org
==========

to

==========
Try converting some tests over to using console_test_launcher.

In general the console_test_launcher execution type is preferable to
the raw execution type because it configures the environment correctly
for the sanitizer runtimes. Without proper configuration, some
sanitizers (in particular UBSan) may not print a full stack trace.

These specific tests have been converted because they run on the
"CFI Linux Full" bot and the linux_chromium_cfi_rel_ng trybot,
which are configured with CFI enabled and with a diagnostic
configuration that uses the UBSan runtime to produce diagnostics
including stack traces.

None of these tests run on chromium.gpu, so they don't seem to need
direct GPU access. I'm not aware of any other reason why they would
need to use the raw execution type either.

I haven't audited every test suite, so it's possible that other test
suites could also be converted.

BUG=732652
R=dpranke@chromium.org
==========

[pcc1, 2017-06-27 01:47:21]

ptal, I've updated the description with more details.

[pcc1, 2017-06-29 19:14:59]

Ping.

[Dirk Pranke, 2017-06-29 20:28:39]

lgtm, thanks!

[pcc1, 2017-06-29 20:43:29]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2017-06-29 20:44:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 22:16:13]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498769009479280, "parent_rev":
"f6cf7568ddef65314d13badf262e96695edbc226", "commit_rev":
"9c98ed29555b35e3d3fcaa0e6fdeecbb87533dbc"}

[commit-bot: I haz the power, 2017-06-29 22:16:27]

Description was changed from

==========
Try converting some tests over to using console_test_launcher.

In general the console_test_launcher execution type is preferable to
the raw execution type because it configures the environment correctly
for the sanitizer runtimes. Without proper configuration, some
sanitizers (in particular UBSan) may not print a full stack trace.

These specific tests have been converted because they run on the
"CFI Linux Full" bot and the linux_chromium_cfi_rel_ng trybot,
which are configured with CFI enabled and with a diagnostic
configuration that uses the UBSan runtime to produce diagnostics
including stack traces.

None of these tests run on chromium.gpu, so they don't seem to need
direct GPU access. I'm not aware of any other reason why they would
need to use the raw execution type either.

I haven't audited every test suite, so it's possible that other test
suites could also be converted.

BUG=732652
R=dpranke@chromium.org
==========

to

==========
Try converting some tests over to using console_test_launcher.

In general the console_test_launcher execution type is preferable to
the raw execution type because it configures the environment correctly
for the sanitizer runtimes. Without proper configuration, some
sanitizers (in particular UBSan) may not print a full stack trace.

These specific tests have been converted because they run on the
"CFI Linux Full" bot and the linux_chromium_cfi_rel_ng trybot,
which are configured with CFI enabled and with a diagnostic
configuration that uses the UBSan runtime to produce diagnostics
including stack traces.

None of these tests run on chromium.gpu, so they don't seem to need
direct GPU access. I'm not aware of any other reason why they would
need to use the raw execution type either.

I haven't audited every test suite, so it's possible that other test
suites could also be converted.

BUG=732652
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2961603003
Cr-Commit-Position: refs/heads/master@{#483514}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c98ed29555b35e3d3fcaa0e6fde...
==========

[commit-bot: I haz the power, 2017-06-29 22:16:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c98ed29555b35e3d3fcaa0e6fde...