Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2961603002: Fix wording for break and continue. (Closed)

Created:
3 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M docs/language/dartLangSpec.tex View 2 chunks +20 lines, -2 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
Lasse Reichstein Nielsen
3 years, 5 months ago (2017-06-26 14:22:55 UTC) #2
eernst
LGTM!
3 years, 5 months ago (2017-06-26 14:47:07 UTC) #3
Paul Berry
lgtm
3 years, 5 months ago (2017-06-26 15:41:26 UTC) #5
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 82a97d8b46d3facfed6920d9822c5d579a468961 (presubmit successful).
3 years, 5 months ago (2017-06-27 08:33:33 UTC) #7
Kevin Millikin (Google)
https://codereview.chromium.org/2961603002/diff/1/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): https://codereview.chromium.org/2961603002/diff/1/docs/language/dartLangSpec.tex#newcode6608 docs/language/dartLangSpec.tex:6608: It is a compile-time error if no such statement ...
3 years, 5 months ago (2017-06-27 11:55:10 UTC) #9
Lasse Reichstein Nielsen
3 years, 5 months ago (2017-06-27 13:23:46 UTC) #10
Message was sent while issue was closed.
On 2017/06/27 11:55:10, Kevin Millikin (Google) wrote:
> I think the phrasing of this whole section is too complicated for what it
says. 
> I suggest not introducing the name $s_E$ for the thing in order to say that
the
> thing exists (and it doesn't really matter if it's the innermost one or not so
> long as there is one).
> 
> I'd suggest something along the lines of:
> 
> If $s_c$ is of the form \code{\CONTINUE{} $L$;}, then it is a compile-time
error
> if $s_c$ is not enclosed in a labeled \code{\AWAIT{} \FOR{}} ....

Much better, I'll do that.

Powered by Google App Engine
This is Rietveld 408576698