[DevTools] Migrate inspector-protocol/{input,network} tests to new harness

[DevTools] Migrate inspector-protocol/{input,network} tests to new harness

BUG=734762
Review-Url: https://codereview.chromium.org/2961493002
Cr-Commit-Position: refs/heads/master@{#482756}
Committed: https://chromium.googlesource.com/chromium/src/+/7f444654e1f42d49e0eaf166eb8a7a615241763d

[dgozman, 2017-06-23 23:31:57]

dgozman@chromium.org changed reviewers:
+ allada@chromium.org

[dgozman, 2017-06-23 23:31:58]

Could you please take a look?

[dgozman, 2017-06-23 23:32:04]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 23:32:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 01:40:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-24 01:40:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[allada, 2017-06-26 22:02:54]

Lets also see about removing the 'url': 'value' pairs to have the key not be in
quotes.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service:2671:
Bug(none) inspector-protocol/network/resource-type.js [ Timeout ]
Any reason we cant try turning these back on?

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/TestExpectations:877: crbug.com/596968 [ Win ]
inspector-protocol/input/eventTimestamp.js [ Failure Pass ]
ditto.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html
(left):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html:72:
<input onfocus="log('focus foo')" onblur="log('blur foo')" id="foo" autofocus>
I am a bit confused here, it appears that autofocus was never working in the old
test? because it has auto-focus, but after the test loads it blurs then runs
test.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.js:51:
window.internals.setFocused(false);
It looks like the old test was bluring then running the test. Here we are
running the test then bluring. I think it may introduce flakeyness if we keep
this pattern in the new test because we do not know what state the focus is in.
Lets clear the log after setFocused() to ensure non-flakeyness.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.js:53:
type('foo');
At this point the field should be blured and we are typing... Does autofocus
cause the focus to move to it if typing in the page with no target?

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.js:2:
let {page, session, dp} = await testRunner.startBlank(``);
let?

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.js:9:
window.logs = [];
In test mode maybe have a "log" function already setup? or use console.log?

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchMouseEvent.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchMouseEvent.js:23:
window.addEventListener('mousemove', logEvent);
This is not relevant to the test, lets remove it.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchMouseEvent.js:72:
})
nit: semi-colon

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent-expected.txt
(left):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent-expected.txt:45:
type: touchend
This probably happened because expectedEventCount is 5 instead of 6.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.js:10:
const expectedEventCount = 5;
lets un-const this and set it to -1.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.js:16:
event.preventDefault();
Lets add an assert here like:

console.assert(expectedEventCount > 0);

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.js:66:
'type': 'mouseMoved',
Add comment here saying something like:

// Should be ignored by the event listeners.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.js:94:

lets add:

await session.evaluateAsync('expectedEventCount = ' + (events.length - 1)); //
One of the mouseMoved events should be ignored.

This should help reduce the chance of people in the future forgetting to change
the expectedEventCount in the future.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js:23:
var receivedOffsets = receivedTimestamps.map(function(timestamp) {
Lets arrow function this since we are here.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js:48:
var sentTimestamps = [0, 5, 10, 15, 20, 25].map(function(offset) {
Lets arrow function this.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js:53:
method: dp.Input.dispatchKeyEvent,
lets bind these to dq.Input and move event into the bind.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js:110:
var msg = await command.method.call(dp.Input, command.event);
And just call the method by itself.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js:114:
testRunner.log(await session.evaluate('verifyTimestamps()'));
It looks like the other tests do a check here to check if all the events were
received by the event listeners before verifying. Maybe do the same?

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/network/resource-type.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/network/resource-type.js:31:
dp.Network.onResponseReceived(event => {
We are introducing a race condition here. The iframe might have received a
response from the evaluate before here.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/network/resource-type.js:31:
dp.Network.onResponseReceived(event => {
Can we add a .once() style helper and inline much of these?

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/network/resource-type.js:52:
const requestId = event.params.requestId;
const

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/network/resource-type.js:73:
var description = 'Resource ' + resource.url + ' got type: ' + resource.gotType
+  ', type: ' + resource.type + ', responseAvailable: ' +
resource.responseAvailable;
Lets remove "type: ' + resource.type..." it's not needed.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/network/websocket-initiator.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/network/websocket-initiator.js:12:
var messageObject = await dp.Network.enable();
Lets not check this failure.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/network/websocket-initiator.js:25:
for (var i = 0; i < initiator.stack.callFrames.length; ++i) {
While we are here lets extract initiator.stack.callFrames into it's own variable
and do something like:

var callFrames = (initiator.stack && initiator.stack.callFrames) ?
initiator.stack.callFrames : [];

[dgozman, 2017-06-26 23:22:08]

PTAL

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service:2671:
Bug(none) inspector-protocol/network/resource-type.js [ Timeout ]
On 2017/06/26 22:02:52, allada wrote:
> Any reason we cant try turning these back on?

Yeah, in a separate patch. Don't want to get this one reverted.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.js:51:
window.internals.setFocused(false);
On 2017/06/26 22:02:53, allada wrote:
> It looks like the old test was bluring then running the test. Here we are
> running the test then bluring. I think it may introduce flakeyness if we keep
> this pattern in the new test because we do not know what state the focus is
in.
> Lets clear the log after setFocused() to ensure non-flakeyness.

Done.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.js:53:
type('foo');
On 2017/06/26 22:02:53, allada wrote:
> At this point the field should be blured and we are typing... Does autofocus
> cause the focus to move to it if typing in the page with no target?

As I understand it, autofocus affects what is focused inside the page, while we
artificially unfocus the page itself for some internal reasons. That should not
reset the focused or to-be-focused element inside.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.js:2:
let {page, session, dp} = await testRunner.startBlank(``);
On 2017/06/26 22:02:53, allada wrote:
> let?

I will follow up with let->var in all tests.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.js:9:
window.logs = [];
On 2017/06/26 22:02:53, allada wrote:
> In test mode maybe have a "log" function already setup? or use console.log?

I think this breaks the absolutely fresh context in test page (which is a very
nice assumption), and those few tests which need logging from inside the test
page can use this trick.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchMouseEvent.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchMouseEvent.js:23:
window.addEventListener('mousemove', logEvent);
On 2017/06/26 22:02:53, allada wrote:
> This is not relevant to the test, lets remove it.

What do you mean? It's in expectations file.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchMouseEvent.js:72:
})
On 2017/06/26 22:02:53, allada wrote:
> nit: semi-colon

Actually, putting semicolon here would break the harness, which expects the test
body to evaluate into function.
Any ideas on how to improve that are welcome!

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent-expected.txt
(left):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent-expected.txt:45:
type: touchend
On 2017/06/26 22:02:53, allada wrote:
> This probably happened because expectedEventCount is 5 instead of 6.

Right. Otherwise the test flakes (and I believe it's marked as such). That's
because our gesture provider waits for more signals to generate touchend that
just a mouseup.

I've updated the test to the version which does not flake in 100 runs.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.js:10:
const expectedEventCount = 5;
On 2017/06/26 22:02:53, allada wrote:
> lets un-const this and set it to -1.

Done.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.js:16:
event.preventDefault();
On 2017/06/26 22:02:53, allada wrote:
> Lets add an assert here like:
> 
> console.assert(expectedEventCount > 0);

I am a bit hesitant on this - expecting flakes due to more events happening.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.js:66:
'type': 'mouseMoved',
On 2017/06/26 22:02:53, allada wrote:
> Add comment here saying something like:
> 
> // Should be ignored by the event listeners.

Done.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.js:94:

On 2017/06/26 22:02:53, allada wrote:
> lets add:
> 
> await session.evaluateAsync('expectedEventCount = ' + (events.length - 1)); //
> One of the mouseMoved events should be ignored.
> 
> This should help reduce the chance of people in the future forgetting to
change
> the expectedEventCount in the future.

Nice idea! Done.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js:23:
var receivedOffsets = receivedTimestamps.map(function(timestamp) {
On 2017/06/26 22:02:53, allada wrote:
> Lets arrow function this since we are here.

Done.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js:48:
var sentTimestamps = [0, 5, 10, 15, 20, 25].map(function(offset) {
On 2017/06/26 22:02:53, allada wrote:
> Lets arrow function this.

Done.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js:53:
method: dp.Input.dispatchKeyEvent,
On 2017/06/26 22:02:54, allada wrote:
> lets bind these to dq.Input and move event into the bind.

Done.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js:110:
var msg = await command.method.call(dp.Input, command.event);
On 2017/06/26 22:02:53, allada wrote:
> And just call the method by itself.

Done.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js:114:
testRunner.log(await session.evaluate('verifyTimestamps()'));
On 2017/06/26 22:02:53, allada wrote:
> It looks like the other tests do a check here to check if all the events were
> received by the event listeners before verifying. Maybe do the same?

Well, we know that commands are coming in the same order to the page, so it's
safe to assume that.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/network/resource-type.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/network/resource-type.js:31:
dp.Network.onResponseReceived(event => {
On 2017/06/26 22:02:54, allada wrote:
> Can we add a .once() style helper and inline much of these?

Doesn't help here unfortunately.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/network/resource-type.js:31:
dp.Network.onResponseReceived(event => {
On 2017/06/26 22:02:54, allada wrote:
> We are introducing a race condition here. The iframe might have received a
> response from the evaluate before here.

Moved, although that's not a race in this case.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/network/resource-type.js:52:
const requestId = event.params.requestId;
On 2017/06/26 22:02:54, allada wrote:
> const

Done.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/network/resource-type.js:73:
var description = 'Resource ' + resource.url + ' got type: ' + resource.gotType
+  ', type: ' + resource.type + ', responseAvailable: ' +
resource.responseAvailable;
On 2017/06/26 22:02:54, allada wrote:
> Lets remove "type: ' + resource.type..." it's not needed.

Done.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/network/websocket-initiator.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/network/websocket-initiator.js:12:
var messageObject = await dp.Network.enable();
On 2017/06/26 22:02:54, allada wrote:
> Lets not check this failure.

Done.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/network/websocket-initiator.js:25:
for (var i = 0; i < initiator.stack.callFrames.length; ++i) {
On 2017/06/26 22:02:54, allada wrote:
> While we are here lets extract initiator.stack.callFrames into it's own
variable
> and do something like:
> 
> var callFrames = (initiator.stack && initiator.stack.callFrames) ?
> initiator.stack.callFrames : [];

Done.

[allada, 2017-06-27 19:08:17]

Just a few things... The most important one is the emulateTouchFromMouseEvent
needs to not be different in the expectations.

lgtm.

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent-expected.txt
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent-expected.txt:35:
-----Event-----
Need rebase?

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js:114:
testRunner.log(await session.evaluate('verifyTimestamps()'));
On 2017/06/26 23:22:08, dgozman wrote:
> On 2017/06/26 22:02:53, allada wrote:
> > It looks like the other tests do a check here to check if all the events
were
> > received by the event listeners before verifying. Maybe do the same?
> 
> Well, we know that commands are coming in the same order to the page, so it's
> safe to assume that.

Yes, but we do not know if the event listeners were executed. I think we need to
do completeTest() after we verify all the events were received by the listeners.
I would be this is why this test was disabled.

[dgozman, 2017-06-27 20:01:54]

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js
(right):

https://codereview.chromium.org/2961493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/input/eventTimestamp.js:114:
testRunner.log(await session.evaluate('verifyTimestamps()'));
On 2017/06/27 19:08:16, allada wrote:
> On 2017/06/26 23:22:08, dgozman wrote:
> > On 2017/06/26 22:02:53, allada wrote:
> > > It looks like the other tests do a check here to check if all the events
> were
> > > received by the event listeners before verifying. Maybe do the same?
> > 
> > Well, we know that commands are coming in the same order to the page, so
it's
> > safe to assume that.
> 
> Yes, but we do not know if the event listeners were executed. I think we need
to
> do completeTest() after we verify all the events were received by the
listeners.
> I would be this is why this test was disabled.

Done.

[dgozman, 2017-06-27 20:02:28]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-06-27 20:02:28]

The patchset sent to the CQ was uploaded after l-g-t-m from allada@chromium.org
Link to the patchset: https://codereview.chromium.org/2961493002/#ps40001
(title: "minor fixes")

[commit-bot: I haz the power, 2017-06-27 20:02:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 21:44:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498593748198150,
"parent_rev": "97b0ab02964dac76c919c24cac8b50ad1141cd24", "commit_rev":
"4cef950e537181d99286fb30fef42971fddcd947"}

[commit-bot: I haz the power, 2017-06-27 21:44:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498593748198150,
"parent_rev": "90556316c9f709600a1862cfa18e061fdec4f342", "commit_rev":
"7f444654e1f42d49e0eaf166eb8a7a615241763d"}

[commit-bot: I haz the power, 2017-06-27 21:44:47]

Description was changed from

==========
[DevTools] Migrate inspector-protocol/{input,network} tests to new harness

BUG=734762
==========

to

==========
[DevTools] Migrate inspector-protocol/{input,network} tests to new harness

BUG=734762

Review-Url: https://codereview.chromium.org/2961493002
Cr-Commit-Position: refs/heads/master@{#482756}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f444654e1f42d49e0eaf166eb8a...
==========

[commit-bot: I haz the power, 2017-06-27 21:44:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7f444654e1f42d49e0eaf166eb8a...