Refactor PostOnSamePage test to ensure the form is posted.

Refactor PostOnSamePage test to ensure the form is posted.

testBrowsingPostOnSamePage is flaky since post form needs some time to post data.
The navigation manager is not synchronized with this action.  The test may goBack 
before the form is actually posted.  Refactor the test to change content when the 
form is posted.

BUG=

Review-Url: https://codereview.chromium.org/2961483002
Cr-Commit-Position: refs/heads/master@{#482116}
Committed: https://chromium.googlesource.com/chromium/src/+/ce3df390dececebfd2c8d306fa682bf65748086a

[huangml1, 2017-06-23 23:07:23]

Description was changed from

==========
Refactor PostOnSamePage test to ensure the form is posted.

BUG=
==========

to

==========
Refactor PostOnSamePage test to ensure the form is posted.

testBrowsingPostOnSamePage is flaky since post form needs some time to post
data.
The navigation manager is not synchronized with this action.  The test may
goBack 
before the form is actually posted.  Refactor the test to change content when
the 
form is posted.

BUG=
==========

[huangml1, 2017-06-23 23:07:49]

huangml@chromium.org changed reviewers:
+ eugenebut@chromium.org

[huangml1, 2017-06-23 23:07:50]

PTAL,thanks

[Eugene But (OOO till 7-30), 2017-06-24 00:26:09]

Thank you for fixing the test.

https://codereview.chromium.org/2961483002/diff/20001/ios/chrome/browser/web/...
File ios/chrome/browser/web/browsing_egtest.mm (right):

https://codereview.chromium.org/2961483002/diff/20001/ios/chrome/browser/web/...
ios/chrome/browser/web/browsing_egtest.mm:84: class TestPostFormResponseProvider
: public web::DataResponseProvider {
Looks like forms_egtest has a response provider that prints HPPT method. Can we
reuse that existing code? Moving |testBrowsingPostToSamePage| to forms_egtest
sounds like a reasonable direction.

[huangml1, 2017-06-24 01:27:15]

Moved two form related tests from browsingTestCase to FormTestCase.  Thanks!

[Eugene But (OOO till 7-30), 2017-06-24 01:32:20]

lgtm!

https://codereview.chromium.org/2961483002/diff/40001/ios/chrome/browser/web/...
File ios/chrome/browser/web/forms_egtest.mm (right):

https://codereview.chromium.org/2961483002/diff/40001/ios/chrome/browser/web/...
ios/chrome/browser/web/forms_egtest.mm:404:
GetFormPostOnSamePageUrl().GetContent())]
nit: Do you want to use a local variable for this URL to improve the formatting?

https://codereview.chromium.org/2961483002/diff/40001/ios/chrome/browser/web/...
ios/chrome/browser/web/forms_egtest.mm:485: GREYAssert([condition
waitWithTimeout:10],
Do we need a constant for this timeout?

[huangml1, 2017-06-24 01:50:32]

The CQ bit was checked by huangml@chromium.org

[huangml1, 2017-06-24 01:50:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2961483002/#ps60001
(title: "Local variable")

[commit-bot: I haz the power, 2017-06-24 01:50:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 02:02:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498269032899110,
"parent_rev": "8d9f82995bc634440aed9ec773861dc376b08e70", "commit_rev":
"ce3df390dececebfd2c8d306fa682bf65748086a"}

[commit-bot: I haz the power, 2017-06-24 02:02:54]

Description was changed from

==========
Refactor PostOnSamePage test to ensure the form is posted.

testBrowsingPostOnSamePage is flaky since post form needs some time to post
data.
The navigation manager is not synchronized with this action.  The test may
goBack 
before the form is actually posted.  Refactor the test to change content when
the 
form is posted.

BUG=
==========

to

==========
Refactor PostOnSamePage test to ensure the form is posted.

testBrowsingPostOnSamePage is flaky since post form needs some time to post
data.
The navigation manager is not synchronized with this action.  The test may
goBack 
before the form is actually posted.  Refactor the test to change content when
the 
form is posted.

BUG=

Review-Url: https://codereview.chromium.org/2961483002
Cr-Commit-Position: refs/heads/master@{#482116}
Committed:
https://chromium.googlesource.com/chromium/src/+/ce3df390dececebfd2c8d306fa68...
==========

[commit-bot: I haz the power, 2017-06-24 02:02:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ce3df390dececebfd2c8d306fa68...