Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2961473002: [Merge to M60] Respect GDK_SCALE and GDK_DPI_SCALE when calculating scale factor (Closed)

Created:
3 years, 6 months ago by Tom Anderson
Modified:
3 years, 6 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, Michael Moss, wfh+watch_chromium.org, oshima
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[Merge to M60] Respect GDK_SCALE and GDK_DPI_SCALE when calculating scale factor > This CL is a followup to [1] which used 'gdk-window-scaling-factor' > and 'gdk-unscaled-dpi' to calculate the scaling factor. I intentially > avoided using the GdkScreen API for this since the required functions > were added in version 3.9.10, and opted to get the settings directly. > This doesn't work all the time though, because GTK allows overriding > these settings with the GDK_SCALE and GDK_DPI_SCALE environment > variables (but only when using the X11 backend). > > This CL makes the change to use those functions, at the cost of > bumping the required GTK dep from 3.3.16 to 3.9.10 (the oldest distro > we support, Trusty, has 3.10.8). > > As a bonus, GdkScreen has a separate scale factor per monitor, so we > can finally stop using the global scale factor for all monitors. > > [1] https://codereview.chromium.org/2899943002/ > > BUG=730757, 732440 > R=erg@chromium.org,thestig@chromium.org > CC=oshima@chromium.org > > Review-Url: https://codereview.chromium.org/2937623006 > Cr-Commit-Position: refs/heads/master@{#480167} BUG=732440 TBR=erg@chromium.org,thestig@chromium.org CC=oshima@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2961473002 Cr-Commit-Position: refs/branch-heads/3112@{#454} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/8d1845c2267b05df565fa33e3c5e2b0e242a21cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -43 lines) Patch
M chrome/browser/ui/libgtkui/gtk_ui.cc View 1 chunk +5 lines, -42 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64_jessie View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961473002/1
3 years, 6 months ago (2017-06-23 21:42:35 UTC) #2
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 21:43:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d1845c2267b05df565fa33e3c5e...

Powered by Google App Engine
This is Rietveld 408576698