Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 2961443002: Remove DCHECK for isolate->counters() (Closed)

Created:
3 years, 6 months ago by kschimpf
Modified:
3 years, 6 months ago
Reviewers:
mtrofin, Mircea Trofin
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Remove DCHECK for isolate->counters() This is a fix to https://codereview.chromium.org/2929853003 that got reverted. The DCHECK checked to see that it was not in a background thread. While this is a property we want for v8, it is also used by blink, and blink violates this property. Therefore, this CL removes the DCHECK for now. BUG=v8:6361 Review-Url: https://codereview.chromium.org/2961443002 Cr-Commit-Position: refs/heads/master@{#46190} Committed: https://chromium.googlesource.com/v8/v8/+/ee0e295d8e829b5c3fc1225b09c7c886e00305f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -222 lines) Patch
M src/compiler/wasm-compiler.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +8 lines, -21 lines 0 comments Download
M src/counters.h View 9 chunks +82 lines, -27 lines 0 comments Download
M src/counters.cc View 4 chunks +39 lines, -21 lines 0 comments Download
M src/isolate.h View 2 chunks +8 lines, -7 lines 0 comments Download
M src/isolate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/wasm/module-compiler.h View 6 chunks +9 lines, -6 lines 0 comments Download
M src/wasm/module-compiler.cc View 19 chunks +26 lines, -44 lines 0 comments Download
M src/wasm/module-decoder.h View 2 chunks +16 lines, -5 lines 0 comments Download
M src/wasm/module-decoder.cc View 5 chunks +54 lines, -62 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/wasm/wasm-module.cc View 7 chunks +9 lines, -12 lines 0 comments Download
M src/wasm/wasm-objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/common/wasm/wasm-module-runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
Mircea Trofin
On 2017/06/23 19:42:09, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
3 years, 6 months ago (2017-06-23 20:07:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961443002/1
3 years, 6 months ago (2017-06-23 20:15:20 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 20:17:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ee0e295d8e829b5c3fc1225b09c7c886e00...

Powered by Google App Engine
This is Rietveld 408576698