Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2961313005:
[Android WebAPKs] Re-extract and optimize runtime library after Android OS upgrade (Closed)
Description[Android WebAPKs] Re-extract and optimize runtime library after Android OS upgrade
The runtime library .dex file is extracted into Chrome's data directory and is
optimized. The path of the optimized dex is dependent on the Android OS version
(because the default optimized dex location is different for each Android OS
version).
This CL re-extracts and optimizes the runtime library when Chrome is run after
an Android OS upgrade. This CL enables WebAPKs to load the runtime library
faster after an Android OS upgrade because they can use the "WebAPK runtime
library optimized dex" and don't need to fall back to the "non-optimized dex".
BUG=738257
Review-Url: https://codereview.chromium.org/2961313005
Cr-Commit-Position: refs/heads/master@{#484610}
Committed: https://chromium.googlesource.com/chromium/src/+/95abea91b81222664fda250b57d2dd835e6bac2a
Patch Set 1 #Patch Set 2 : Merge branch 'master' into os_upgrade #
Messages
Total messages: 21 (10 generated)
pkotwicz@chromium.org changed reviewers: + yfriedman@chromium.org
Yaron, can you please take a look? I didn't find a standard way for doing things after an OS upgrade. BackgroundTaskSchedulerPrefs.java also stores the Android OS version in SharedPreferences
lgtm
pkotwicz@chromium.org changed reviewers: + dominickn@chromium.org
Dominick for OWNERS
lgtm % minor nit: "dependant" in CL description -> "dependent"
Description was changed from ========== [Android WebAPKs] Re-extract and optimize runtime library after Android OS upgrade The runtime library .dex file is extracted into Chrome's data directory and is optimized. The path of the optimized dex is dependant on the Android OS version (because the default optimized dex location is different for each Android OS version). This CL re-extracts and optimizes the runtime library when Chrome is run after an Android OS upgrade. This CL enables WebAPKs to load the runtime library faster after an Android OS upgrade because they can use the "WebAPK runtime library optimized dex" and don't need to fall back to the "non-optimized dex". BUG=738257 ========== to ========== [Android WebAPKs] Re-extract and optimize runtime library after Android OS upgrade The runtime library .dex file is extracted into Chrome's data directory and is optimized. The path of the optimized dex is dependent on the Android OS version (because the default optimized dex location is different for each Android OS version). This CL re-extracts and optimizes the runtime library when Chrome is run after an Android OS upgrade. This CL enables WebAPKs to load the runtime library faster after an Android OS upgrade because they can use the "WebAPK runtime library optimized dex" and don't need to fall back to the "non-optimized dex". BUG=738257 ==========
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Related: I found this which may help simplify DexOptimizer by automatically telling you where to put generated code: https://developer.android.com/reference/android/support/v4/content/ContextCom...
Unfortunately Context#getCodeCacheDir() is L+.
On 2017/07/06 14:43:11, pkotwicz wrote: > Unfortunately Context#getCodeCacheDir() is L+. Note I said ContextCompat (i.e. from support library). The intention is to handle sdk versions for you
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by pkotwicz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dominickn@chromium.org, yfriedman@chromium.org Link to the patchset: https://codereview.chromium.org/2961313005/#ps40001 (title: "Merge branch 'master' into os_upgrade")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499352862456150,
"parent_rev": "20548e47b8881bb32efa2d9b8db489d7b20eaf39", "commit_rev":
"95abea91b81222664fda250b57d2dd835e6bac2a"}
Message was sent while issue was closed.
Description was changed from ========== [Android WebAPKs] Re-extract and optimize runtime library after Android OS upgrade The runtime library .dex file is extracted into Chrome's data directory and is optimized. The path of the optimized dex is dependent on the Android OS version (because the default optimized dex location is different for each Android OS version). This CL re-extracts and optimizes the runtime library when Chrome is run after an Android OS upgrade. This CL enables WebAPKs to load the runtime library faster after an Android OS upgrade because they can use the "WebAPK runtime library optimized dex" and don't need to fall back to the "non-optimized dex". BUG=738257 ========== to ========== [Android WebAPKs] Re-extract and optimize runtime library after Android OS upgrade The runtime library .dex file is extracted into Chrome's data directory and is optimized. The path of the optimized dex is dependent on the Android OS version (because the default optimized dex location is different for each Android OS version). This CL re-extracts and optimizes the runtime library when Chrome is run after an Android OS upgrade. This CL enables WebAPKs to load the runtime library faster after an Android OS upgrade because they can use the "WebAPK runtime library optimized dex" and don't need to fall back to the "non-optimized dex". BUG=738257 Review-Url: https://codereview.chromium.org/2961313005 Cr-Commit-Position: refs/heads/master@{#484610} Committed: https://chromium.googlesource.com/chromium/src/+/95abea91b81222664fda250b57d2... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/95abea91b81222664fda250b57d2... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
