Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: ui/views/bubble/tray_bubble_view.h

Issue 2961313003: Touch gestures for System Tray/ IME/ Stylus/ Notifications (Closed)
Patch Set: Fixed msw's comments. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/bubble/tray_bubble_view.h
diff --git a/ui/views/bubble/tray_bubble_view.h b/ui/views/bubble/tray_bubble_view.h
index 7fa7034855bea6d7729b536d48776f42aed8e5e6..01903d673476a4e3680e7bd90656fabc54be4edd 100644
--- a/ui/views/bubble/tray_bubble_view.h
+++ b/ui/views/bubble/tray_bubble_view.h
@@ -52,13 +52,13 @@ class VIEWS_EXPORT TrayBubbleView : public BubbleDialogDelegateView,
// Called when the view is destroyed. Any pointers to the view should be
// cleared when this gets called.
- virtual void BubbleViewDestroyed() = 0;
+ virtual void BubbleViewDestroyed();
// Called when the mouse enters/exits the view.
// Note: This event will only be called if the mouse gets actively moved by
// the user to enter the view.
- virtual void OnMouseEnteredView() = 0;
- virtual void OnMouseExitedView() = 0;
+ virtual void OnMouseEnteredView();
+ virtual void OnMouseExitedView();
// Called to register/unregister accelerators for TrayBubbleView.
// TrayBubbleView wants to register those accelerators at the global level.
@@ -68,22 +68,23 @@ class VIEWS_EXPORT TrayBubbleView : public BubbleDialogDelegateView,
// not called.
virtual void RegisterAccelerators(
const std::vector<ui::Accelerator>& accelerators,
- TrayBubbleView* tray_bubble_view) = 0;
- virtual void UnregisterAllAccelerators(
- TrayBubbleView* tray_bubble_view) = 0;
+ TrayBubbleView* tray_bubble_view);
+ virtual void UnregisterAllAccelerators(TrayBubbleView* tray_bubble_view);
// Called from GetAccessibleNodeData(); should return the appropriate
// accessible name for the bubble.
- virtual base::string16 GetAccessibleNameForBubble() = 0;
+ virtual base::string16 GetAccessibleNameForBubble();
// Should return true if extra keyboard accessibility is enabled.
// TrayBubbleView will put focus on the default item if extra keyboard
// accessibility is enabled.
- virtual bool ShouldEnableExtraKeyboardAccessibility() = 0;
+ virtual bool ShouldEnableExtraKeyboardAccessibility();
// Called when a bubble wants to hide/destroy itself (e.g. last visible
// child view was closed).
- virtual void HideBubble(const TrayBubbleView* bubble_view) = 0;
+ virtual void HideBubble(const TrayBubbleView* bubble_view);
+
+ virtual bool ProcessGestureEventForBubble(ui::GestureEvent* event);
tdanderson 2017/07/17 22:44:38 Please add some documentation here for this new fu
minch1 2017/07/18 03:59:00 Done.
private:
DISALLOW_COPY_AND_ASSIGN(Delegate);
@@ -158,6 +159,7 @@ class VIEWS_EXPORT TrayBubbleView : public BubbleDialogDelegateView,
void OnMouseEntered(const ui::MouseEvent& event) override;
void OnMouseExited(const ui::MouseEvent& event) override;
void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
+ void OnGestureEvent(ui::GestureEvent* event) override;
// Overridden from MouseWatcherListener
void MouseMovedOutOfHost() override;

Powered by Google App Engine
This is Rietveld 408576698